Skip to content

Commit 028b46f

Browse files
authored
Refactor into a structure that supports editable installation (#83)
* Refactor into a structure that supports editable installation * Fix resource file path in setup.py * Update skill tests to prevent legacy skill loading * Skip failing OVOS intent tests * Comment out occasionally failing test case * Try re-enabling OVOS Intent tests with updated `neon-minerva` * Fix typo in neon-minerva test extra deps * Update neon-minerva test dependency
1 parent 6f0d9b7 commit 028b46f

191 files changed

Lines changed: 65 additions & 263 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/skill_tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@ jobs:
1616
# TODO: Padacioso handling extra words with high-conf.
1717
test_padacioso: false
1818
test_padatious: true
19+
skill_entrypoint: "skill-date_time.neongeckocom"
1920
skill_resource_tests:
2021
uses: neongeckocom/.github/.github/workflows/skill_test_resources.yml@master
22+
with:
23+
skill_entrypoint: "skill-date_time.neongeckocom"
2124
skill_install_tests:
2225
uses: neongeckocom/.github/.github/workflows/skill_test_installation.yml@master
2326
with:
24-
test_osm: false
27+
test_osm: false

LICENSE

Lines changed: 0 additions & 201 deletions
This file was deleted.

requirements/test.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
neon-minerva[padatious]~=0.3
1+
neon-minerva[padatious]~=0.3,>=0.3.1a1
22
ovos-lingua-franca>=0.4.8a3

setup.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838

3939
def get_requirements(requirements_filename: str):
40-
requirements_file = path.join(BASE_PATH, requirements_filename)
40+
requirements_file = path.join(BASE_PATH, "requirements", requirements_filename)
4141
with open(requirements_file, 'r', encoding='utf-8') as r:
4242
requirements = r.readlines()
4343
requirements = [r.strip() for r in requirements if r.strip()
@@ -59,7 +59,7 @@ def get_requirements(requirements_filename: str):
5959

6060
def find_resource_files():
6161
resource_base_dirs = ("locale", "ui", "vocab", "dialog", "regex")
62-
base_dir = BASE_PATH
62+
base_dir = path.join(BASE_PATH, SKILL_PKG)
6363
package_data = ["skill.json"]
6464
for res in resource_base_dirs:
6565
if path.isdir(path.join(base_dir, res)):
@@ -89,12 +89,11 @@ def find_resource_files():
8989
url=f'https://github.com/NeonGeckoCom/{SKILL_NAME}',
9090
license='BSD-3-Clause',
9191
install_requires=get_requirements("requirements.txt"),
92-
extras_require={"test": get_requirements("requirements/test.txt")},
92+
extras_require={"test": get_requirements("test.txt")},
9393
author='Neongecko',
9494
author_email='developers@neon.ai',
9595
long_description=long_description,
9696
long_description_content_type="text/markdown",
97-
package_dir={SKILL_PKG: ""},
9897
packages=[SKILL_PKG],
9998
package_data={SKILL_PKG: find_resource_files()},
10099
include_package_data=True,
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)