Don't show OBS ghost beacons whilst LIFE_DYING (#1791)

* Only consider drawing beacons for LIFE_ALIVE and LIFE_DEAD

And not during LIFE_DYING

* Refactor

const ptr

Author: Rainyan

src/game/client/neo/ui/neo_hud_ghost_beacons.cpp

@@ -85,9 +85,20 @@ void CNEOHud_GhostBeacons::DrawNeoHudElement()
 	if (!ShouldDraw())
 		return;
 
-	auto ghoster = IsLocalPlayerSpectator()
-		? ToNEOPlayer(UTIL_PlayerByIndex(GetSpectatorTarget()))
-		: C_NEO_Player::GetLocalNEOPlayer();
+	auto localPlayer = C_NEO_Player::GetLocalNEOPlayer();
+	if (!localPlayer)
+		return;
+
+	// Only consider drawing beacons if alive or dead, but not LIFE_DYING (the death animation)
+	if (localPlayer->m_lifeState != LIFE_ALIVE &&
+		localPlayer->m_lifeState != LIFE_DEAD)
+	{
+		return;
+	}
+
+	auto ghoster = localPlayer->IsObserver()
+		? ToNEOPlayer(localPlayer->GetObserverTarget())
+		: localPlayer;
 
 	if (!ghoster || !ghoster->m_bCarryingGhost ||
 		ghoster->GetTeamNumber() < FIRST_GAME_TEAM ||
@@ -97,19 +108,19 @@ void CNEOHud_GhostBeacons::DrawNeoHudElement()
 	}
 	Assert(ghoster->GetTeamNumber() < TEAM__TOTAL);
 
-	C_WeaponGhost* ghost;
+	const C_WeaponGhost* ghost;
 	if (sv_neo_ctg_ghost_beacons_when_inactive.GetBool())
 	{
-		ghost = assert_cast<C_WeaponGhost*>(GetNeoWepWithBits(ghoster, NEO_WEP_GHOST));
+		ghost = assert_cast<const C_WeaponGhost*>(GetNeoWepWithBits(ghoster, NEO_WEP_GHOST));
 		AssertMsg(ghoster->m_bCarryingGhost == !!ghost,
 			"ghost ptr and m_bCarryingGhost mismatch");
 	}
 	else
 	{
 		auto weapon = assert_cast<C_NEOBaseCombatWeapon*>(ghoster->GetActiveWeapon());
-		ghost = (weapon && weapon->IsGhost()) ? static_cast<C_WeaponGhost*>(weapon) : nullptr;
+		ghost = (weapon && weapon->IsGhost()) ? static_cast<const C_WeaponGhost*>(weapon) : nullptr;
 		AssertMsg(ghoster->m_bCarryingGhost ==
-			!!assert_cast<C_WeaponGhost*>(GetNeoWepWithBits(ghoster, NEO_WEP_GHOST)),
+			!!assert_cast<const C_WeaponGhost*>(GetNeoWepWithBits(ghoster, NEO_WEP_GHOST)),
 			"ghost ptr and m_bCarryingGhost mismatch");
 	}