Skip to content

Silence leaf shadow count assert spam #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rainyan merged 2 commits into from
Jun 11, 2026
+4 −22
Merged

Silence leaf shadow count assert spam #1986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348caf3
Revert commit 84a63ed
Rainyan Jun 11, 2026
9ebe423
Only assert once for the legacy shadowleafs alloc warning
Rainyan Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions src/game/client/clientleafsystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,20 +1004,6 @@ void CClientLeafSystem::RemoveShadowFromRenderables( ClientLeafShadowHandle_t ha
//-----------------------------------------------------------------------------
void CClientLeafSystem::AddShadowToLeaf( int leaf, ClientLeafShadowHandle_t shadow )
{
#if defined(DEBUG) && defined(NEO)
static constexpr const char *ASSERT_MAPS_TO_IGNORE[] = {
"ntre_engage_ctg", "ntre_skyline_ctg", "ntre_rise_ctg"
};
bool bIgnoreAssert = false;
for (const char *pszMapCmp : ASSERT_MAPS_TO_IGNORE)
{
if (FStrEq(MapName(), pszMapCmp))
{
bIgnoreAssert = true;
break;
}
}
#endif // defined(DEBUG) && defined(NEO)
m_ShadowsInLeaf.AddElementToBucket( leaf, shadow );

// Add the shadow exactly once to all renderables in the leaf
Expand All @@ -1034,15 +1020,11 @@ void CClientLeafSystem::AddShadowToLeaf( int leaf, ClientLeafShadowHandle_t shad
info.m_EnumCount = m_ShadowEnum;
}

#ifdef DEBUG
#ifdef NEO
// Few maps will happily blows past this limit, but it seems to be fine.
// Just ignoring this specific case in debug.
if (!bIgnoreAssert)
#endif
{
Assert(m_ShadowsInLeaf.NumAllocated() < 2000);
}
// don't nuke dev build perf by spamming the assert every frame
AssertOnce(m_ShadowsInLeaf.NumAllocated() < 2000);
#else
Assert(m_ShadowsInLeaf.NumAllocated() < 2000);
#endif

i = m_RenderablesInLeaf.NextElement(i);
Expand Down
Loading