Skip to content

Fix not initialized m_pFilterPanel pointer#1988

Open
Masterkatze wants to merge 1 commit into
NeotokyoRebuild:masterfrom
Masterkatze:fix_filter_panel_crash
Open

Fix not initialized m_pFilterPanel pointer#1988
Masterkatze wants to merge 1 commit into
NeotokyoRebuild:masterfrom
Masterkatze:fix_filter_panel_crash

Conversation

@Masterkatze

Copy link
Copy Markdown
Contributor

Description

m_pFilterPanel pointer is not initialized by default, which can skip memory allocation under if ( m_pFilterPanel == NULL ) check, and then we use it in m_pFilterPanel->SetVisible( false );

Toolchain

  • Linux GCC Distro Native [Arch Linux, g++ (GCC) 16.1.1 20260430]

Linked Issues

@Masterkatze Masterkatze added the Bug Report Bug Reports made through the "Report Issue" interface in GitHub. label Jun 11, 2026
@Agiel Agiel requested a review from a team June 11, 2026 20:45
@AdamTadeusz

Copy link
Copy Markdown
Contributor

ifdef neo? nullptr? Could also initialize the nullptr in the header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Report Bug Reports made through the "Report Issue" interface in GitHub.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when loading into a map (release build, gcc 16.1.1)

4 participants