Sparse neoAssets checkout and NEO_EXTRA_ASSETS_ALT_PATH#1992
Open
nullsystem wants to merge 1 commit into
Open
Conversation
In the CMake add NEO_EXTRA_ASSETS_ALT_PATH option as an alternate neoAssets path to use rather than going through FetchContent. This is used mainly for the CI build to first sparse fetch the neoAssets files as it doesn't need all the files especially since some files are very large and not even used in the build process. This cuts down the overall time to do the whole process. This can also be useful for devs if they prefer to juse fetch it from their already checkedout neoAssets. * fixes NeotokyoRebuild#1991
Masterkatze
reviewed
Jun 12, 2026
| option(NEO_BUILD_VGUI_CONTROLS "Build vgui_controls library" ON) | ||
| option(NEO_COPY_LIBRARIES "Copy libraries to bin directory by default" ON) | ||
| option(NEO_EXTRA_ASSETS "Copy extra assets into game/neo" ON) | ||
| option(NEO_EXTRA_ASSETS_ALT_PATH "Alternate location to fetch the extra assets" "") |
Contributor
There was a problem hiding this comment.
option is for BOOL only, use set(... CACHE PATH ...) here
| "${NEO_EXTRA_ASSETS_ALT_PATH}/neo" | ||
| "${CMAKE_SOURCE_DIR}/../game/neo") | ||
| else() | ||
| include(FetchContent) # once in the project to include the module |
Contributor
There was a problem hiding this comment.
Remove comments here and on line 609 while we changing this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the CMake add NEO_EXTRA_ASSETS_ALT_PATH option as an alternate neoAssets path to use rather than going through FetchContent. This is used mainly for the CI build to first sparse fetch the neoAssets files as it doesn't need all the files especially since some files are very large and not even used in the build process. This cuts down the overall time to do the whole process. This can also be useful for devs if they prefer to juse fetch it from their already checkedout neoAssets.
Toolchain
Linked Issues