Skip to content

User Management security improvement#745

Merged
NeptuneHub merged 2 commits into
mainfrom
devel
Jul 10, 2026
Merged

User Management security improvement#745
NeptuneHub merged 2 commits into
mainfrom
devel

Conversation

@NeptuneHub

@NeptuneHub NeptuneHub commented Jul 10, 2026

Copy link
Copy Markdown
Owner

This PR is to improve the user management security.

PR test builds:

Comment thread app_auth.py Dismissed
Comment thread app_auth.py Dismissed
Comment thread app_auth.py Dismissed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements JWT session validation and revocation against the database, requiring password confirmation for sensitive user-management actions (creation, deletion, and password changes) while exempting bearer-token callers. It adds a password_changed_at timestamp to track and invalidate older sessions, with corresponding updates to the database schema, backup restore runner, UI, and test suites. The review feedback suggests wrapping the datetime.datetime.fromtimestamp call in a try...except block to prevent potential unhandled exceptions (such as ValueError or TypeError) when parsing malformed iat claims.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app_auth.py
@sonarqubecloud

sonarqubecloud Bot commented Jul 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
48 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NeptuneHub NeptuneHub merged commit a954c92 into main Jul 10, 2026
28 checks passed
@NeptuneHub NeptuneHub deleted the devel branch July 10, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants