LoKr support#1464
Open
Koratahiu wants to merge 19 commits into
Open
Conversation
Can be used when alpha = sqrt(dim) so not really needed
dxqb
requested changes
May 24, 2026
| scale = self.alpha / self.dim | ||
|
|
||
| # DoRA for LoKr | ||
| if self.weight_decompose: |
Collaborator
There was a problem hiding this comment.
do we need DoRA for LoKr?
my intuition: DoRA is already a niche technique, DoRA with LoKr even more so. but I could be wrong.
If we keep it, I see the following issues
Contributor
Author
There was a problem hiding this comment.
I don't think it's of any use, but people use it with LoKr anyway. It can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened #1080