Skip to content

ctk UI file split#1564

Merged
dxqb merged 13 commits into
mergefrom
ctk_copy
Jul 1, 2026
Merged

ctk UI file split#1564
dxqb merged 13 commits into
mergefrom
ctk_copy

Conversation

@dxqb

@dxqb dxqb commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR copies all ctk UI files to 3 files:

  • Base*View.py
  • Ctk*View.py
  • *Controller.py

It doesn't do anything else, just copies. It is the basis for #1445 and I'll keep it a separate commit in git history for good "blame" tracability.

dxqb and others added 13 commits May 10, 2026 14:11
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mirrors the change from upstream commit e928dda (Remove COFT #1447),
which removed COFT from LoraTab.py. The merge didn't carry it across
the rename to CtkLoraTabView.py.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Was sitting on the same row at columns 3-4; now on its own row directly
below the toggle for clearer visual grouping.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erge

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dxqb dxqb changed the base branch from master to merge July 1, 2026 04:14
@dxqb dxqb merged commit 10890e5 into merge Jul 1, 2026
1 check passed
@dxqb dxqb deleted the ctk_copy branch July 1, 2026 04:16
@dxqb dxqb restored the ctk_copy branch July 1, 2026 04:16
dxqb added a commit to dxqb/OneTrainer that referenced this pull request Jul 1, 2026
…bstraction

Nerogar/merge received PR Nerogar#1564 as a squash-merge with tree identical
to ctk_copy's tip. ctk_abstraction already contains all of ctk_copy's
real commits, so -X ours is safe here: there is no content on
Nerogar/merge beyond what's already in ctk_abstraction.

# Conflicts:
#	modules/ui/BaseAdditionalEmbeddingsTabView.py
#	modules/ui/BaseCaptionUIView.py
#	modules/ui/BaseCloudTabView.py
#	modules/ui/BaseConceptTabView.py
#	modules/ui/BaseConceptWindowView.py
#	modules/ui/BaseConvertModelUIView.py
#	modules/ui/BaseGenerateCaptionsWindowView.py
#	modules/ui/BaseGenerateMasksWindowView.py
#	modules/ui/BaseLoraTabView.py
#	modules/ui/BaseModelTabView.py
#	modules/ui/BaseOffloadingWindowView.py
#	modules/ui/BaseProfilingWindowView.py
#	modules/ui/BaseSampleFrameView.py
#	modules/ui/BaseSampleParamsWindowView.py
#	modules/ui/BaseSampleWindowView.py
#	modules/ui/BaseSamplingTabView.py
#	modules/ui/BaseSchedulerParamsWindowView.py
#	modules/ui/BaseTimestepDistributionWindowView.py
#	modules/ui/BaseTopBarView.py
#	modules/ui/BaseTrainUIView.py
#	modules/ui/BaseTrainingTabView.py
#	modules/ui/BaseVideoToolUIView.py
#	modules/ui/CaptionUI.py
#	modules/ui/CaptionUIController.py
#	modules/ui/CtkGenerateCaptionsWindowView.py
#	modules/ui/CtkGenerateMasksWindowView.py
#	modules/ui/CtkSchedulerParamsWindowView.py
#	modules/ui/GenerateCaptionsWindow.py
#	modules/ui/GenerateMasksWindow.py
#	modules/ui/SampleWindow.py
#	modules/ui/SampleWindowController.py
#	modules/ui/SchedulerParamsWindow.py
#	modules/ui/VideoToolUI.py
#	modules/ui/VideoToolUIController.py
dxqb added a commit to dxqb/OneTrainer that referenced this pull request Jul 1, 2026
…erogar#1445) into pyside

Nerogar/merge's tip is a squash-merge of ctk_abstraction, tree-identical
to our ctk_abstraction/pyside_copy ancestors already in pyside's history.
-X ours plus manual conflict resolution below keeps pyside's tree unchanged.
@dxqb dxqb deleted the ctk_copy branch July 1, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant