Skip to content

Commit 7c8c75c

Browse files
author
Sqoia Dev Agent
committed
fix: modal dialogs now visible — z-index, sizing, overflow fixes
Modals (AllocationModal, BillingRuleModal, RefundModal) were dimming the background but the dialog content was invisible because: - overflow:hidden on the app container created a stacking context that trapped position:fixed elements - Modal z-index was 1000, bumped to 9999 - Removed overflow:hidden from app container and html/body - Added explicit width/height (100vw/100vh) to modal overlay - Added min-width, max-width, max-height, overflow-y to modal body - Modal content now scrolls independently if it exceeds 80vh
1 parent fb0ab4c commit 7c8c75c

2 files changed

Lines changed: 17 additions & 8 deletions

File tree

src/slurmledger.css

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ html, body, #root {
22
height: 100%;
33
margin: 0;
44
padding: 0;
5-
overflow: hidden;
65
}
76

87
body {
@@ -286,19 +285,30 @@ nav button:hover {
286285
/* Modal overlay for refunds and other dialogs */
287286
.modal-overlay {
288287
position: fixed;
289-
inset: 0;
288+
top: 0;
289+
left: 0;
290+
right: 0;
291+
bottom: 0;
292+
width: 100vw;
293+
height: 100vh;
290294
background: rgba(0, 0, 0, 0.5);
291295
display: flex;
292296
align-items: center;
293297
justify-content: center;
294-
z-index: 1000;
298+
z-index: 9999;
295299
}
296300

297301
.modal {
298302
background: #fff;
299-
border-radius: 6px;
300-
padding: 1.5em;
301-
box-shadow: 0 8px 32px rgba(0, 0, 0, 0.2);
303+
border-radius: 8px;
304+
padding: 1.5em 2em;
305+
box-shadow: 0 8px 32px rgba(0, 0, 0, 0.3);
306+
min-width: 400px;
307+
max-width: 600px;
308+
max-height: 80vh;
309+
overflow-y: auto;
310+
z-index: 10000;
311+
position: relative;
302312
}
303313

304314
.modal h3 {

src/slurmledger.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6241,8 +6241,7 @@ function App() {
62416241
style: {
62426242
display: 'flex',
62436243
flexDirection: 'column',
6244-
height: '100vh',
6245-
overflow: 'hidden'
6244+
height: '100vh'
62466245
}
62476246
},
62486247

0 commit comments

Comments
 (0)