Skip to content

Commit b164f18

Browse files
committed
Fixed typos in comments.
1 parent 1b4b9a5 commit b164f18

12 files changed

Lines changed: 30 additions & 94 deletions

Infrastructure_as_Code/Ansible/Volume_Management/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@ Workload Factory Link, please refer to the [NetApp Workload Factory documentatio
88

99
The list of playbooks included in this folder is as follows:
1010
| Playbook Name | Description |
11+
|:-----|:------|
1112
| clone_volume.yaml | Clones an existing volume.|
1213
| create_cifs_share.yaml | Creates a new CIFS share on an existing volume.|
1314
| create_cifs_unix_symlink_mapping.yaml | Creates a CIFS symlink mapping. |
1415
| create_snapshot.yaml | Creates a snapshot of an existing volume.|
1516
| create_volume.yaml | Creates a new volume.|
16-
| create_volume_and_share.yaml | Creates a new volume with a CIFS share that points to it. It also sets autosize to grow and enables ONTAP efficiencies.|
17+
| create_volume_and_share.yaml | Creates a new volume with a CIFS share that points to it. It also enables ONTAP efficiencies and potentially sets the autosize mode.|
1718
| delete_cifs_share.yaml | Deletes an existing CIFS share.|
1819
| delete_snapshot.yaml | Deletes an existing snapshot.|
1920
| delete_volume.yaml | Deletes an existing volume.|
@@ -90,7 +91,7 @@ ok: [localhost]
9091
TASK [Set use_lambda to true if lambda_function_name is provided.] *********************************************************
9192
ok: [localhost]
9293

93-
TASK [Set aws_provide to "default" if not provided.] ***********************************************************************
94+
TASK [Set aws_profile to "default" if not provided.] ***********************************************************************
9495
ok: [localhost]
9596

9697
TASK [Set junction path to "/<volume_name>" if not provided.] **************************************************************

Infrastructure_as_Code/Ansible/Volume_Management/clone_volume.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Title: clone_volume.yaml
22

33
---
4-
- name: Playbook to clones a volume in an FSx for ONTAP file system.
4+
- name: Playbook to clone a volume in an FSx for ONTAP file system.
55
hosts: localhost
66
collections:
77
- netapp.ontap
@@ -30,7 +30,7 @@
3030
use_lambda: true
3131
when: lambda_function_name is defined
3232

33-
- name: Set aws_provide to "default" if not provided.
33+
- name: Set aws_profile to "default" if not provided.
3434
set_fact:
3535
aws_profile: "default"
3636
when: aws_profile is not defined

Infrastructure_as_Code/Ansible/Volume_Management/create_cifs_share.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Title: create_a_cifs_share
1+
# Title: create_cifs_share.yaml
22

33
---
44
- name: Playbook to create a CIFS share
@@ -30,7 +30,7 @@
3030
use_lambda: true
3131
when: lambda_function_name is defined
3232

33-
- name: Set aws_provide to "default" if not provided.
33+
- name: Set aws_profile to "default" if not provided.
3434
set_fact:
3535
aws_profile: "default"
3636
when: aws_profile is not defined

Infrastructure_as_Code/Ansible/Volume_Management/create_cifs_unix_symlink_mapping.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
use_lambda: true
3333
when: lambda_function_name is defined
3434

35-
- name: Set aws_provide to "default" if not provided.
35+
- name: Set aws_profile to "default" if not provided.
3636
set_fact:
3737
aws_profile: "default"
3838
when: aws_profile is not defined

Infrastructure_as_Code/Ansible/Volume_Management/create_volume.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
password: "{{ lookup('amazon.aws.aws_secret', '{{ secret_name }}.password', nested=true) }}"
5757
no_log: true
5858

59-
- name: Set security_style to unix if not provide.
59+
- name: Set security_style to unix if not provided.
6060
set_fact:
6161
security_style: "unix"
6262
when: security_style is not defined

Infrastructure_as_Code/Ansible/Volume_Management/create_volume_and_share.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
junction_path: "/{{ volume_name }}"
6262
when: junction_path is not defined
6363

64-
- name: Set security_style to ntfs if not provide.
64+
- name: Set security_style to ntfs if not provided.
6565
set_fact:
6666
security_style: "ntfs"
6767
when: security_style is not defined
@@ -81,7 +81,7 @@
8181
share_name: "{{ volume_name }}"
8282
when: share_name is not defined
8383

84-
- name: Give efficiency_mode a default if it hasn't already set.
84+
- name: Give efficiency_mode a default if it hasn't already been set.
8585
set_fact:
8686
efficiency_mode: "enabled"
8787
when: efficiency_mode is not defined
@@ -127,8 +127,8 @@
127127
aws_region: "{{ aws_region }}"
128128
function_name: "{{ lambda_function_name }}"
129129
mode: "{{ autosize_mode }}"
130-
maximum_size: "{{ autosize_maximum_size | default(omit) }}"
131-
minimum_size: "{{ autosize_minimum_size | default(omit) }}"
130+
maximum_size: "{{ autosize_max_size | default(omit) }}"
131+
minimum_size: "{{ autosize_min_size | default(omit) }}"
132132
hostname: "{{ fsxn_hostname }}"
133133
username: "{{ username }}"
134134
password: "{{ password }}"

Infrastructure_as_Code/Ansible/Volume_Management/delete_cifs_share.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Title: delete_a_cifs_share
1+
# Title: delete_cifs_share.yaml
22

33
---
44
- name: Playbook to delete a CIFS share
@@ -29,7 +29,7 @@
2929
use_lambda: true
3030
when: lambda_function_name is defined
3131

32-
- name: Set aws_provide to "default" if not provided.
32+
- name: Set aws_profile to "default" if not provided.
3333
set_fact:
3434
aws_profile: "default"
3535
when: aws_profile is not defined
@@ -55,7 +55,7 @@
5555
password: "{{ lookup('amazon.aws.aws_secret', '{{ secret_name }}.password', nested=true) }}"
5656
no_log: true
5757

58-
- name: Create CIFS Share
58+
- name: Delete CIFS Share
5959
netapp.ontap.na_ontap_cifs:
6060
state: absent
6161
name: "{{ delete_share_name }}"

Infrastructure_as_Code/Ansible/Volume_Management/delete_volume_and_share.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
when: vars[item] is undefined
2020
loop:
2121
- volume_name
22-
- volume_size
2322
- vserver
2423
- secret_name
2524
- fsxn_hostname
@@ -30,7 +29,7 @@
3029
use_lambda: true
3130
when: lambda_function_name is defined
3231

33-
- name: Set aws_provide to "default" if not provided.
32+
- name: Set aws_profile to "default" if not provided.
3433
set_fact:
3534
aws_profile: "default"
3635
when: aws_profile is not defined

Infrastructure_as_Code/Ansible/Volume_Management/get_volume_info.yaml

Lines changed: 0 additions & 69 deletions
This file was deleted.

Infrastructure_as_Code/Ansible/Volume_Management/set_volume_autosize.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@
4949
lambda_function_name: ""
5050
when: lambda_function_name is not defined
5151

52+
- name: Ensure autosize_mode is valid.
53+
fail:
54+
msg: "autosize_mode must be either 'grow', 'grow_shrink', or 'off'."
55+
when: autosize_mode not in ['grow', 'off', 'grow_shrink']
56+
5257
- name: Get username and password from AWS secret
5358
set_fact:
5459
username: "{{ lookup('amazon.aws.aws_secret', '{{ secret_name }}.username', nested=true) }}"

0 commit comments

Comments
 (0)