Add CloudWatch to ontap monitor services#235
Merged
Conversation
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds CloudWatch support for alerting on ONTAP services, enhances volume-level inode utilization alerts, and improves EMS message filtering and matching. Key changes include replacing direct logger/sns calls with a centralized sendAlert function, refining configuration handling (including CloudWatch endpoint variables), and updating README documentation to reflect the new monitoring features and AWS endpoint requirements.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Monitoring/monitor-ontap-services/monitor_ontap_services.py | Replaces direct alert calls with sendAlert; adds helper functions (lagTimeStr, findMatch) and updates environment variable handling for CloudWatch. |
| Monitoring/monitor-ontap-services/README.md | Updates installation instructions and matching conditions documentation to include CloudWatch and revised endpoint requirements. |
Comments suppressed due to low confidence (1)
Monitoring/monitor-ontap-services/monitor_ontap_services.py:507
- [nitpick] Avoid using 'str' as a variable name since it shadows the built-in type; consider renaming it to 'timeStr' or a similar descriptive name.
str = lagTimeStr(lagSeconds)
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…xpected scheduled update.
…e (over 100%) of the last scheduled update.
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
…will be enabled by default.
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following major changes were made: