Updated so the watching CloudWatch alert could handle the SNS topic being in another region.

[kcantrel]

No description provided.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull Request Overview

Adds cross-region SNS support via a watchdog Lambda, enhances API call resilience, and updates docs

• Append return_timeout to ONTAP API endpoints and streamline volumeRecords handling
• Introduce CloudFormation watchdog Lambda with IAM role and permissions to publish to SNS in another region
• Update README for the new watchdog feature and correct the Lambda layer link

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
monitor_ontap_services.py	Added return_timeout query parameter to all API endpoints and refactored storage utilization to use volumeRecords
cloudformation.yaml	Defined watchdog IAM role, Lambda, permission, and new watchdogRoleArn parameter; wired alarm to invoke it
README.md	Fixed download URL path, added watchdog feature description, and refined parameter table

Files not reviewed (1)

• Monitoring/monitor-ontap-services/updateMonOntapServiceCFTemplate: Language not supported

Comments suppressed due to low confidence (3)

Monitoring/monitor-ontap-services/cloudformation.yaml:27

• [nitpick] Parameter names use PascalCase, so watchdogRoleArn should be renamed to WatchdogRoleArn for consistency with other parameters.

-          - watchdogRoleArn

Monitoring/monitor-ontap-services/README.md:77

• Typo: 'aother' should be 'another'.

-    - Create a Lambda function to send the CloudWatch alarm alert to an SNS topic. This is done so the SNS topic can be in aother region since CloudWatch doesn't support doing that natively.

Monitoring/monitor-ontap-services/cloudformation.yaml:354

• CreateWatchdogAlarm condition is not defined in the Conditions section; this will cause deployment errors. Define it or use the appropriate existing condition.

    Condition: CreateWatchdogAlarm

[Copilot]

This loop does not guard against volumeRecords being None if the initial API call failed. Consider checking if volumeRecords: before iterating to avoid a runtime error.

Suggested change

	for record in volumeRecords:
	if rule[key] and record["state"].lower() == "offline":
	uniqueIdentifier = f'{record["uuid"]}_{key}_{rule[key]}'
	if volumeRecords:
	for record in volumeRecords:
	if rule[key] and record["state"].lower() == "offline":
	uniqueIdentifier = f'{record["uuid"]}_{key}_{rule[key]}'