Skip to content

Added volume_cifs_share_create#267

Merged
shmueldanan merged 5 commits into
mainfrom
add_create_cifs_share
Apr 15, 2026
Merged

Added volume_cifs_share_create#267
shmueldanan merged 5 commits into
mainfrom
add_create_cifs_share

Conversation

@kcantrel

Copy link
Copy Markdown
Collaborator

No description provided.

@kcantrel kcantrel requested a review from Copilot February 11, 2026 21:49
@github-actions

github-actions Bot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

Management-Utilities/Workload-Factory-API-Samples/wf_utils:136

  • run_curl now supports PATCH, but the function header comment/documentation still lists only GET/POST/PUT/DELETE. Please update the documented supported methods (and parameter description for data payload) to match the new behavior so callers don’t miss that PATCH is valid.
    POST|PUT|PATCH)
      curl -X "$method" -sw "%{http_code},%{errormsg}" "$url" \
         -H "Accept: $accept" "${extraHeaders[@]}" \
         -H "Content-Type:application/json" \
         -H "Authorization: Bearer $token" --data "$data" -o $output > $errorOutput

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Management-Utilities/Workload-Factory-API-Samples/volume_cifs_share_create Outdated
Comment thread Management-Utilities/Workload-Factory-API-Samples/volume_cifs_share_create Outdated
@shmueldanan shmueldanan merged commit d5efe30 into main Apr 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants