Added CIFS Share Ansible and Terraform examples.#276
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Adds new CIFS share examples for both Terraform and Ansible, and updates repository documentation/navigation to reference the new samples.
Changes:
- Added a new Terraform “Miscellaneous” area with a CIFS share example.
- Added Ansible playbooks to create/delete a volume + CIFS share, and updated volume playbook behavior.
- Updated various READMEs to include/reorder links and improve formatting.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates top-level TOC to include new Terraform Miscellaneous link and reorder items |
| Infrastructure_as_Code/README.md | Updates IaC TOC and copyright year |
| Infrastructure_as_Code/Terraform/README.md | Adds Miscellaneous entry and renames deploy-fsx-ontap entry (currently has a broken link casing) |
| Infrastructure_as_Code/Terraform/Miscellaneous/README.md | New README documenting the Miscellaneous Terraform examples |
| Infrastructure_as_Code/Terraform/Miscellaneous/create_cifs_share.tf | New Terraform example to create an FSxN volume and CIFS share |
| Infrastructure_as_Code/Terraform/deploy-fsx-ontap/standalone-module/README.md | Minor markdown formatting updates in generated docs |
| Infrastructure_as_Code/Terraform/deploy-fsx-ontap/module/README.md | Minor markdown formatting updates in generated docs |
| Infrastructure_as_Code/Ansible/Volume_Management/README.md | Documents new Ansible playbooks and updates variable table |
| Infrastructure_as_Code/Ansible/Volume_Management/create_volume.yaml | Adds volume_security_style to volume creation |
| Infrastructure_as_Code/Ansible/Volume_Management/create_volume_and_share.yaml | New playbook to create a volume and CIFS share |
| Infrastructure_as_Code/Ansible/Volume_Management/delete_volume_and_share.yaml | New playbook intended to delete a volume and CIFS share (currently has multiple correctness issues) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Infrastructure_as_Code/Terraform/Miscellaneous/create_cifs_share.tf
Outdated
Show resolved
Hide resolved
Infrastructure_as_Code/Ansible/Volume_Management/create_volume_and_share.yaml
Show resolved
Hide resolved
Infrastructure_as_Code/Ansible/Volume_Management/delete_volume_and_share.yaml
Show resolved
Hide resolved
Infrastructure_as_Code/Ansible/Volume_Management/create_volume_and_share.yaml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.