Feature/cstackex 117 (#34)

* CSTAKEX-117 Password encoding

* CSTACKEX-117 Decode the password

* CSTACKEX-117 resolve check style issues

* CSTACKEX-117 Remove unnecesaary loggers

---------

Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

Author: suryag1201

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

@@ -183,7 +183,6 @@ public DataStore initialize(Map<String, Object> dsInfos) {
         details.put(Constants.SIZE, capacityBytes.toString());
 
         ProtocolType protocol = ProtocolType.valueOf(details.get(Constants.PROTOCOL));
-
         // Connect to ONTAP and create volume
         long volumeSize = Long.parseLong(details.get(Constants.SIZE));
         OntapStorage ontapStorage = new OntapStorage(

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/provider/StorageProviderFactory.java

@@ -21,6 +21,9 @@
 
 import com.cloud.utils.component.ComponentContext;
 import com.cloud.utils.exception.CloudRuntimeException;
+
+import java.nio.charset.StandardCharsets;
+
 import org.apache.cloudstack.storage.feign.model.OntapStorage;
 import org.apache.cloudstack.storage.service.StorageStrategy;
 import org.apache.cloudstack.storage.service.UnifiedNASStrategy;
@@ -36,6 +39,14 @@ public class StorageProviderFactory {
     public static StorageStrategy getStrategy(OntapStorage ontapStorage) {
         ProtocolType protocol = ontapStorage.getProtocol();
         s_logger.info("Initializing StorageProviderFactory with protocol: " + protocol);
+        String decodedPassword = new String(java.util.Base64.getDecoder().decode(ontapStorage.getPassword()), StandardCharsets.UTF_8);
+        ontapStorage = new OntapStorage(
+            ontapStorage.getUsername(),
+            decodedPassword,
+            ontapStorage.getStorageIP(),
+            ontapStorage.getSvmName(),
+            ontapStorage.getSize(),
+            protocol);
         switch (protocol) {
             case NFS3:
                 UnifiedNASStrategy unifiedNASStrategy = new UnifiedNASStrategy(ontapStorage);

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

@@ -75,7 +75,7 @@ public UnifiedNASStrategy(OntapStorage ontapStorage) {
         String baseURL = Constants.HTTPS + ontapStorage.getStorageIP();
         this.feignClientFactory = new FeignClientFactory();
         this.nasFeignClient = feignClientFactory.createClient(NASFeignClient.class, baseURL);
-        this.volumeFeignClient = feignClientFactory.createClient(VolumeFeignClient.class,baseURL );
+        this.volumeFeignClient = feignClientFactory.createClient(VolumeFeignClient.class, baseURL);
         this.jobFeignClient = feignClientFactory.createClient(JobFeignClient.class, baseURL );
     }
 

ui/src/views/infra/AddPrimaryStorage.vue

@@ -938,7 +938,7 @@ export default {
         } else if (values.provider === 'NetApp ONTAP') {
           params['details[0].storageIP'] = values.ontapIP
           params['details[0].username'] = values.ontapUsername
-          params['details[0].password'] = values.ontapPassword
+          params['details[0].password'] = btoa(values.ontapPassword)
           params['details[0].svmName'] = values.ontapSvmName
           params['details[0].protocol'] = values.protocol
           values.managed = true