CSTACKEX-18_2: reverting memory snapshot workflow and eroring out for now

Author: rajiv-jain-netapp

core/src/main/java/com/cloud/agent/api/RestoreVMFromMemoryFileAnswer.java

@@ -98,16 +98,23 @@ public Answer execute(RestoreVMFromMemoryFileCommand cmd, LibvirtComputingResour
             }
 
             // Restore VM from memory file using virsh restore
-            String virshPath = Script.getExecutableAbsolutePath("virsh");
-            String restoreResult = Script.runSimpleBashScript(
-                    virshPath + " restore " + memoryFilePath + " --bypass-cache");
-
-            if (restoreResult != null && !restoreResult.isEmpty()) {
+            // Use Script class for better error handling - it returns null on success
+            Script restoreScript = new Script(Script.getExecutableAbsolutePath("virsh"),
+                    serverResource.getCmdsTimeout(), logger);
+            restoreScript.add("restore");
+            restoreScript.add(memoryFilePath);
+            restoreScript.add("--bypass-cache");
+
+            String restoreResult = restoreScript.execute();
+            // Script.execute() returns null on success, error message on failure
+            if (restoreResult != null) {
                 logger.error("virsh restore failed for VM " + vmName + ": " + restoreResult);
                 return new RestoreVMFromMemoryFileAnswer(cmd, false,
                         "Failed to restore VM from memory file: " + restoreResult);
             }
 
+            logger.info("RestoreVMFromMemoryFileCommandWrapper: virsh restore completed successfully for VM " + vmName);
+
             // Verify VM is now running
             Domain restoredDomain = null;
             VirtualMachine.PowerState vmState = VirtualMachine.PowerState.PowerUnknown;