Skip to content

feat: remove iscsi service enable/disable #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hardikl wants to merge 1 commit into from
Closed

feat: remove iscsi service enable/disable #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions integration/test/iscsi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,6 @@ func TestIscsiProtocol(t *testing.T) {
expectedOntapErr string
verifyAPI ontapVerifier
}{
{
name: "Clean iSCSI service",
input: ClusterStr + "delete iscsi service in marketing svm",
expectedOntapErr: "because it does not exist",
verifyAPI: ontapVerifier{api: "api/protocols/san/iscsi/services?svm.name=marketing", validationFunc: deleteObject},
},
{
name: "Create iSCSI service",
input: ClusterStr + "create iscsi service target named alias " + rn("tgpath") + " on the marketing svm",
expectedOntapErr: "",
verifyAPI: ontapVerifier{api: "api/protocols/san/iscsi/services?svm.name=marketing", validationFunc: createObject},
},
{
name: "Clean cluster scope network interface",
Comment thread
Hardikl marked this conversation as resolved.
input: ClusterStr + "delete cluster scope network interface named " + rn("cl_mg"),
Expand Down Expand Up @@ -80,18 +68,6 @@ func TestIscsiProtocol(t *testing.T) {
expectedOntapErr: "because it does not exist",
verifyAPI: ontapVerifier{api: "api/network/ip/interfaces?name=" + rn("svg1") + "&scope=svm", validationFunc: deleteObject},
},
{
name: "Update iSCSI service",
input: ClusterStr + "disabled iscsi service on the marketing svm",
expectedOntapErr: "",
verifyAPI: ontapVerifier{},
},
{
name: "Clean iSCSI service",
input: ClusterStr + "delete iscsi service in marketing svm",
expectedOntapErr: "because it does not exist",
verifyAPI: ontapVerifier{api: "api/protocols/san/iscsi/services?svm.name=marketing", validationFunc: deleteObject},
},
}

cfg, err := config.ReadConfig(ConfigFile)
Expand Down
2 changes: 1 addition & 1 deletion integration/test/tools_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func (a *Agent) ChatWithResponse(ctx context.Context, t *testing.T, userMessage
if expectedOntapErrorStr != "" && strings.Contains(err.Error(), expectedOntapErrorStr) {
slog.Debug("Expected tool error", slog.String("tool", toolName), slog.Any("error", err))
} else {
t.Errorf("Tool %q returned error LLM will retry: %v", toolName, err)
t.Errorf("Tool %q args %v returned error LLM will retry: %v", toolName, args, err)
}
result = "Error: " + err.Error()
}
Expand Down
Loading