Skip to content

feat: add svm tools and consumed in iscsi tests#104

Merged
rahulguptajss merged 1 commit into
mainfrom
hl_svm
Apr 10, 2026
Merged

feat: add svm tools and consumed in iscsi tests#104
rahulguptajss merged 1 commit into
mainfrom
hl_svm

Conversation

@Hardikl
Copy link
Copy Markdown
Contributor

@Hardikl Hardikl commented Apr 10, 2026

No description provided.

@Hardikl Hardikl requested a review from cgrinds as a code owner April 10, 2026 10:40
Copilot AI review requested due to automatic review settings April 10, 2026 10:40
@Hardikl Hardikl requested a review from rahulguptajss as a code owner April 10, 2026 10:40
@cla-bot cla-bot Bot added the cla-signed label Apr 10, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class SVM (Storage Virtual Machine) create/delete support to the MCP server so higher-level workflows (notably iSCSI integration tests) can ensure the required SVM exists before provisioning dependent SAN objects.

Changes:

  • Introduces an SVM tool parameter type and registers new MCP tools: create_svm and delete_svm.
  • Implements server handlers plus REST client calls for creating and deleting SVMs via /api/svm/svms.
  • Updates iSCSI integration test flow to create/cleanup the SVM used by subsequent iSCSI/network interface operations.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tool/tool.go Adds tool.SVM parameter schema (cluster + svm_name) for the new tools.
server/svm.go Implements MCP tool handlers CreateSVM/DeleteSVM with cluster locking and basic validation.
server/server.go Registers create_svm and delete_svm tools in the MCP server.
rest/svm.go Adds REST client methods to POST/DELETE SVMs (including UUID lookup for delete).
ontap/ontap.go Adds ontap.SVM payload type used for SVM create requests.
integration/test/iscsi_test.go Ensures the test SVM is created before iSCSI service operations and cleaned up afterward.
descriptions/descriptions.go Adds tool descriptions for create_svm and delete_svm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rest/svm.go
@rahulguptajss rahulguptajss merged commit 0c88e3a into main Apr 10, 2026
23 checks passed
@rahulguptajss rahulguptajss deleted the hl_svm branch April 10, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants