feat: add svm tools and consumed in iscsi tests#104
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class SVM (Storage Virtual Machine) create/delete support to the MCP server so higher-level workflows (notably iSCSI integration tests) can ensure the required SVM exists before provisioning dependent SAN objects.
Changes:
- Introduces an
SVMtool parameter type and registers new MCP tools:create_svmanddelete_svm. - Implements server handlers plus REST client calls for creating and deleting SVMs via
/api/svm/svms. - Updates iSCSI integration test flow to create/cleanup the SVM used by subsequent iSCSI/network interface operations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tool/tool.go | Adds tool.SVM parameter schema (cluster + svm_name) for the new tools. |
| server/svm.go | Implements MCP tool handlers CreateSVM/DeleteSVM with cluster locking and basic validation. |
| server/server.go | Registers create_svm and delete_svm tools in the MCP server. |
| rest/svm.go | Adds REST client methods to POST/DELETE SVMs (including UUID lookup for delete). |
| ontap/ontap.go | Adds ontap.SVM payload type used for SVM create requests. |
| integration/test/iscsi_test.go | Ensures the test SVM is created before iSCSI service operations and cleaned up afterward. |
| descriptions/descriptions.go | Adds tool descriptions for create_svm and delete_svm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.