Don't always try to set locked status of security accounts#599
Open
brinnjoyce wants to merge 2 commits into
Open
Don't always try to set locked status of security accounts#599brinnjoyce wants to merge 2 commits into
brinnjoyce wants to merge 2 commits into
Conversation
(cherry picked from commit 736e4be3ae7155226aea482060a3861785640ab7)
chuyich
reviewed
Nov 6, 2025
chuyich
requested changes
Nov 6, 2025
Contributor
chuyich
left a comment
There was a problem hiding this comment.
Fine with the first change But think about the case I shared in the comment.
…true. On update only send if plan doesn't match state
78a86a2 to
289780c
Compare
Contributor
|
We try to avoid defaults going forward as API may change defaults in future, this creates a dependency, lets try to have a solution without default |
suhasbshekar
requested changes
Dec 4, 2025
Contributor
suhasbshekar
left a comment
There was a problem hiding this comment.
We try to avoid defaults going forward as API may change defaults in future, this creates a dependency, lets try to have a solution without default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #598
This would still run into permissions issues if the account was locked or if you tried to manually define the locked status. But it allows a security account like the below to be created on an FSx Ontap