658 - enhancement - netapp-ontap_s3_bucket

[csahu9]

Issue #658

• added new option cors_rules, requires ONTAP 9.16 or later.

ACC test result:

TF_ACC=1 go test `go list ./... | grep -e provider` -v -run=TestAccS3BucketResource
=== RUN   TestAccS3BucketResource
--- PASS: TestAccS3BucketResource (28.95s)
PASS
ok      github.com/netapp/terraform-provider-netapp-ontap/internal/provider/protocols   28.964s

[chuyich]

I don't see this is required on 9.16.1 from https://docs.netapp.com/us-en/ontap-restapi/swagger-ui/index.html#/Object-Store/s3_bucket_create. Can you share the document link here?

[csahu9]

As per the POST model in swagger,

[chuyich]

It's optional but why it has to be at least one?

[csahu9]

Because empty list is not a valid value for expose_headers parameter.
If we set below:
"cors": {
"rules": [
{
"max_age_seconds": 1,
"allowed_origins": [ "*" ],
"allowed_methods": [ "GET", "POST", "PUT", "DELETE" ],
"expose_headers": []
}
]
}

REST doesn't return any value for expose_headers:

So, I have added a condition to have at least one element if mentioned in config, for the better management of state and idempotency.

[chuyich]

Why it's 9.16.1 not 9.16?

[csahu9]

The doc, https://docs.netapp.com/us-en/ontap-cli/vserver-create.html
mentions the versions as 9.x.1.
Currently Ansible ontap modules handles version constraints as 9.x.1 instead of 9.x!

Should we incorporate the same in terraform repo too?
Let me update the doc to mention this as 9.16 for now.

[chuyich]

1. The versions are not consistent in the code and doc.
2. expose header: optional vs at least one
3. can you share the test case? removal/update-to-empty case

[csahu9]

1. The versions are not consistent in the code and doc.
2. expose header: optional vs at least one
3. can you share the test case? removal/update-to-empty case

I've added more test cases in protocols_s3_bucket_resource_test.go to test removing a single cors rule and setting cors_rules to an empty list.

[root@scs000952326 protocols]# TF_ACC=1 go test `go list ./... | grep -e provider` -v -run=TestAccS3BucketResource
=== RUN   TestAccS3BucketResource
--- PASS: TestAccS3BucketResource (40.86s)
PASS
ok      github.com/netapp/terraform-provider-netapp-ontap/internal/provider/protocols   40.879s