Fix REST API volume lookup to ignore volume state

VinayKumarHavanur · web-flow · commit dcf3a06e845a · 2025-12-23T20:08:06.000+05:30
diff --git a/storage_drivers/ontap/api/ontap_rest.go b/storage_drivers/ontap/api/ontap_rest.go
@@ -607,7 +607,7 @@ func (c *RestClient) getVolumeByNameAndStyle(
 	style string,
 	fields []string,
 ) (*models.Volume, error) {
-	result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, models.VolumeStateOnline, fields)
+	result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, "", fields)
 	if err != nil {
 		return nil, err
 	}
diff --git a/storage_drivers/ontap/api/ontap_rest_test.go b/storage_drivers/ontap/api/ontap_rest_test.go
@@ -4637,6 +4637,8 @@ func TestGetAllVolumesByPatternStyleAndState_failure(t *testing.T) {
 		{"InvalidStyle", "InvalidState", mockGetVolumeResponse, true},
 		{models.VolumeStyleFlexvol, "InvalidState", mockGetVolumeResponse, true},
 		{models.VolumeStyleFlexvol, models.VolumeStateOnline, mockGetVolumeResponseNumRecordsNil, false},
+		{models.VolumeStyleFlexvol, "", mockGetVolumeResponse, false},
+		{models.VolumeStyleFlexvol, "", mockGetVolumeResponseNumRecordsNil, false},
 	}
 
 	for _, test := range tests {

Original file line number	Diff line number	Diff line change
`@@ -607,7 +607,7 @@ func (c *RestClient) getVolumeByNameAndStyle(`
`607`	`607`	`style string,`
`608`	`608`	`fields []string,`
`609`	`609`	`) (*models.Volume, error) {`
`610`		`- result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, models.VolumeStateOnline, fields)`
	`610`	`+ result, err := c.getAllVolumesByPatternStyleAndState(ctx, volumeName, style, "", fields)`
`611`	`611`	`if err != nil {`
`612`	`612`	`return nil, err`
`613`	`613`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4637,6 +4637,8 @@ func TestGetAllVolumesByPatternStyleAndState_failure(t *testing.T) {`
`4637`	`4637`	`{"InvalidStyle", "InvalidState", mockGetVolumeResponse, true},`
`4638`	`4638`	`{models.VolumeStyleFlexvol, "InvalidState", mockGetVolumeResponse, true},`
`4639`	`4639`	`{models.VolumeStyleFlexvol, models.VolumeStateOnline, mockGetVolumeResponseNumRecordsNil, false},`
	`4640`	`+ {models.VolumeStyleFlexvol, "", mockGetVolumeResponse, false},`
	`4641`	`+ {models.VolumeStyleFlexvol, "", mockGetVolumeResponseNumRecordsNil, false},`
`4640`	`4642`	`}`
`4641`	`4643`
`4642`	`4644`	`for _, test := range tests {`