Updated docs to reflect use of MIB::OID usage in yaml and code (librenms#19053)

Author: laf

doc/Developing/os/Health-Information.md

@@ -10,6 +10,7 @@ the values we expect to see the data in:
 | ------------------------------- | --------------------------- |
 | airflow                         | cfm                         |
 | ber                             | ratio                       |
+| bitrate                         | bps                         |
 | charge                          | %                           |
 | chromatic_dispersion            | ps/nm                       |
 | cooling                         | W                           |
@@ -23,6 +24,7 @@ the values we expect to see the data in:
 | humidity                        | %                           |
 | load                            | %                           |
 | loss                            | %                           |
+| percent                         | %                           |
 | power                           | W                           |
 | power_consumed                  | kWh                         |
 | power_factor                    | ratio                       |
@@ -34,11 +36,9 @@ the values we expect to see the data in:
 | state                           | #                           |
 | temperature                     | C                           |
 | tv_signal                       | dBmV                        |
-| bitrate                         | bps                         |
 | voltage                         | V                           |
 | waterflow                       | l/m                         |
-| percent                         | %                           |
-| signal_loss                       | dB                          |
+| signal_loss                     | dB                          |
 
 ### Simple health discovery
 
@@ -58,35 +58,31 @@ all the data you need. We will use netbotz as an example here.
 `resources/definitions/os_discovery/netbotz.yaml`
 
 ```yaml
-mib: NETBOTZV2-MIB
 modules:
     sensors:
         airflow:
             options:
                 skip_value_lt: 0
             data:
                 -
-                    oid: airFlowSensorTable
-                    value: airFlowSensorValue
+                    oid: NETBOTZV2-MIB::airFlowSensorTable
+                    value: NETBOTZV2-MIB::airFlowSensorValue
                     divisor: 10
                     num_oid: '.1.3.6.1.4.1.5528.100.4.1.5.1.2.{{ $index }}'
-                    descr: '{{ $airFlowSensorLabel }}'
+                    descr: '{{ NETBOTZV2-MIB::airFlowSensorLabel }}'
                     index: 'airFlowSensorValue.{{ $index }}'
 ```
 
-At the top you can define one or more mibs to be used in the lookup of data:
-
-`mib: NETBOTZV2-MIB`
-For use of multiple MIB files separate them with a colon: `mib: NETBOTZV2-MIB:SECOND-MIB`
+Please ensure that you use the format MIB-NAME::OID for all references to OIDs.
 
 For `data:` you have the following options:
 
 The only sensor we have defined here is airflow. The available options
 are as follows:
 
-- `oid` (required): This is the name of the table you want to snmp walk for data.
+- `oid` (required): This is the name of the table you want to snmp walk for data, prepended by the MIB-NAME, I.e `NETBOTZV2-MIB::airFlowSensorTable`.
 - `value` (optional): This is the key within the table that contains
-  the value. If not provided will use `oid`
+  the value, prepended by the MIB-NAME, I.e: `NETBOTZV2-MIB::airFlowSensorValue`. If not provided will use `oid`.
 - `num_oid` (required for PullRequests): If not provided, this parameter should be computed
   automatically by discovery process. This parameter is still required to
   submit a pull request. This is the numerical OID that contains
@@ -145,7 +141,7 @@ For `options:` you have the following available:
 - `skip_value_gt`: If sensor value is greater than this, skip the discovery.
 
 Multiple variables can be used in the sensor's definition. The syntax
-is `{{ $variable }}`. Any oid in the current table can be used, as
+is `{{ MIB-NAME::variable }}`. Any oid in the current table can be used, as
 well as pre-fetched data. The index ($index) and the sub_indexes (in
 case the oid is indexed multiple times) are also available: if
 $index="1.20", then $subindex0="1" and $subindex1="20".