dbd: clear AFPVOL_NOV2TOEACONV flag to allow AD to xattr conversion#3152
Conversation
when afp.conf is set to 'convert appledouble = no' we enable the AFPVOL_NOV2TOEACONV flag, however the dbd tool should always be allowed to convert AD to xattr so clear the flag when running dbd
🤖 Augment PR SummarySummary: 🤖 Was this summary useful? React with 👍 or 👎 |
|
📊 Performance DashboardCommit: 🔥 Spectest (AFP 3.4) - FlameGraphNetatalk Code-time: 2.0% · Runtime: 68s · Stacks: 1148 🔥 Click the preview to open the interactive flamegraph (zoom + search). 🔝 Top 10 leaf functions
📈 Speedtest (AFP 3.4) - PerfGraph🔝 Peak throughput per operation
⏱️ Lantest (AFP 3.4) - LatencyGraphAvg total runtime: 5068 ms · Avg time per AFP op: 0.098 ms 🐢 All operations (avg runtime, in test order)
|
|
@rdmark this had quite a performance hit having it always check, so forcing on always for dbd is may be a performance regression. I think we need to restrict this to just the dbd tooling rather than the whole dbd backend? |
|
@andylemin this has nothing to do with the CNID backend of the same name: the code modified here is only ever executed by the |






when afp.conf is set to 'convert appledouble = no' we enable the AFPVOL_NOV2TOEACONV flag, however the dbd tool should always be allowed to convert AD to xattr so clear the flag when running dbd