Skip to content

Commit e9f9603

Browse files
vantomanForenche
authored andcommitted
Revert "sched: Improve the scheduler"
This reverts commit 2d2b0b1. Signed-off-by: Yaroslav Furman <yaro330@gmail.com> Signed-off-by: Fiqri Ardyansyah <fiqri15072019@gmail.com> Signed-off-by: Forenche <prahul2003@gmail.com>
1 parent fbc5657 commit e9f9603

5 files changed

Lines changed: 3 additions & 26 deletions

File tree

include/linux/sched/sysctl.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ extern unsigned int sysctl_sched_cpu_high_irqload;
4141
extern unsigned int sysctl_sched_boost;
4242
extern unsigned int sysctl_sched_group_upmigrate_pct;
4343
extern unsigned int sysctl_sched_group_downmigrate_pct;
44-
extern unsigned int sysctl_sched_conservative_pl;
4544
extern unsigned int sysctl_sched_many_wakeup_threshold;
4645
extern unsigned int sysctl_sched_walt_rotate_big_tasks;
4746
extern unsigned int sysctl_sched_min_task_util_for_boost;

kernel/sched/cpufreq_schedutil.c

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,6 @@ static inline bool use_pelt(void)
161161
#endif
162162
}
163163

164-
static inline bool conservative_pl(void)
165-
{
166-
#ifdef CONFIG_SCHED_WALT
167-
return sysctl_sched_conservative_pl;
168-
#else
169-
return false;
170-
#endif
171-
}
172-
173164
static unsigned long freq_to_util(struct sugov_policy *sg_policy,
174165
unsigned int freq)
175166
{
@@ -383,7 +374,6 @@ static void sugov_walt_adjust(struct sugov_cpu *sg_cpu, unsigned long *util,
383374
unsigned long nl = sg_cpu->walt_load.nl;
384375
unsigned long cpu_util = sg_cpu->util;
385376
bool is_hiload;
386-
unsigned long pl = sg_cpu->walt_load.pl;
387377

388378
if (unlikely(!sysctl_sched_use_walt_cpu_util))
389379
return;
@@ -398,11 +388,8 @@ static void sugov_walt_adjust(struct sugov_cpu *sg_cpu, unsigned long *util,
398388
if (is_hiload && nl >= mult_frac(cpu_util, NL_RATIO, 100))
399389
*util = *max;
400390

401-
if (sg_policy->tunables->pl) {
402-
if (conservative_pl())
403-
pl = mult_frac(pl, TARGET_LOAD, 100);
404-
*util = max(*util, pl);
405-
}
391+
if (sg_policy->tunables->pl)
392+
*util = max(*util, sg_cpu->walt_load.pl);
406393
}
407394

408395
static void sugov_update_single(struct update_util_data *hook, u64 time,

kernel/sched/sched.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2122,6 +2122,7 @@ cpu_util_freq_walt(int cpu, struct sched_walt_cpu_load *walt_load)
21222122

21232123
nl = div64_u64(nl * (100 + boost),
21242124
walt_cpu_util_freq_divisor);
2125+
pl = div64_u64(pl * (100 + boost), 100);
21252126

21262127
walt_load->prev_window_util = util;
21272128
walt_load->nl = nl;

kernel/sched/walt.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,6 @@ void set_window_start(struct rq *rq)
928928
unsigned int max_possible_efficiency = 1;
929929
unsigned int min_possible_efficiency = UINT_MAX;
930930

931-
unsigned int sysctl_sched_conservative_pl;
932931
unsigned int sysctl_sched_many_wakeup_threshold = 1000;
933932

934933
#define INC_STEP 8

kernel/sysctl.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -372,15 +372,6 @@ static struct ctl_table kern_table[] = {
372372
.extra1 = &neg_three,
373373
.extra2 = &three,
374374
},
375-
{
376-
.procname = "sched_conservative_pl",
377-
.data = &sysctl_sched_conservative_pl,
378-
.maxlen = sizeof(unsigned int),
379-
.mode = 0644,
380-
.proc_handler = proc_dointvec_minmax,
381-
.extra1 = &zero,
382-
.extra2 = &one,
383-
},
384375
{
385376
.procname = "sched_many_wakeup_threshold",
386377
.data = &sysctl_sched_many_wakeup_threshold,

0 commit comments

Comments
 (0)