Skip to content

Commit c2a5624

Browse files
authored
fix: using NeCheckbox instead of input and improved network error message (#758)
1 parent 3c8ec41 commit c2a5624

3 files changed

Lines changed: 7 additions & 23 deletions

File tree

src/components/controller/ControllerAppLogin.vue

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
getAxiosErrorMessage,
99
getStringFromStorage,
1010
NeButton,
11+
NeCheckbox,
1112
NeHeading,
1213
NeInlineNotification,
1314
NeLink,
@@ -215,18 +216,7 @@ function isFormInvalid() {
215216
/>
216217
<div class="flex items-center justify-between">
217218
<div class="flex items-center">
218-
<input
219-
id="remember-me"
220-
v-model="rememberMe"
221-
name="remember-me"
222-
type="checkbox"
223-
class="h-4 w-4 rounded border-gray-300 text-primary-600 focus:ring-primary-600 dark:border-gray-700 dark:text-primary-600 dark:focus:ring-primary-400"
224-
/>
225-
<label
226-
for="remember-me"
227-
class="ml-3 block text-sm leading-6 text-gray-900 dark:text-gray-100"
228-
>{{ t('login.remember_me') }}</label
229-
>
219+
<NeCheckbox id="remember-me" v-model="rememberMe" :label="t('login.remember_me')" />
230220
</div>
231221

232222
<div class="text-sm leading-6">

src/components/standalone/StandaloneAppLogin.vue

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ import {
1414
getAxiosErrorMessage,
1515
deleteFromStorage,
1616
getStringFromStorage,
17-
saveToStorage
17+
saveToStorage,
18+
NeCheckbox
1819
} from '@nethesis/vue-components'
1920
import { useLoginStore } from '@/stores/standalone/standaloneLogin'
2021
import { onMounted, ref, watch } from 'vue'
@@ -261,18 +262,11 @@ async function verifyOtp() {
261262
/>
262263
<div class="flex items-center justify-between">
263264
<div class="flex items-center">
264-
<input
265+
<NeCheckbox
265266
id="remember-me"
266267
v-model="rememberMe"
267-
name="remember-me"
268-
type="checkbox"
269-
class="h-4 w-4 rounded border-gray-300 text-primary-600 focus:ring-primary-600 dark:border-gray-700 dark:text-primary-600 dark:focus:ring-primary-400"
268+
:label="t('login.remember_me')"
270269
/>
271-
<label
272-
for="remember-me"
273-
class="ml-3 block text-sm leading-6 text-gray-900 dark:text-gray-100"
274-
>{{ t('login.remember_me') }}</label
275-
>
276270
</div>
277271
<div class="text-sm leading-6">
278272
<NeLink

src/i18n/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
},
7676
"error": {
7777
"generic_error": "Something went wrong",
78-
"network_error": "Network error",
78+
"network_error": "Network error. Check your connection and reload the page.",
7979
"network_timeout": "Network timeout",
8080
"http_401": "Authentication error",
8181
"http_403": "Authorization error",

0 commit comments

Comments
 (0)