fix(ovpn-rw): correct command for client certificate name extraction#1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that occurs when a user tries to regenerate the entire PKI of a RoadWarrior server with one or more users whose names contain a
.character (e.g.mario.rossi,franco.verdi).Before the fix, during regeneration a new certificate was created using the part of the name before the first
.. Meanwhile, the certificate to be renewed kept its original name and remained revoked (e.g. formario.rossi.crt, a new valid and renewed certificate was created with the namemario.crt).This fix resolves the issue by using the UNIX basename command and removing the .crt suffix.