test: minor unit tests fixes

Author: MaksymMalicki

blockchain/state_version.go

@@ -48,7 +48,7 @@ func ValidateStateVersion(disk db.KeyValueStore, useNewState bool) error {
 }
 
 func bucketHasData(disk db.KeyValueStore, bucket db.Bucket) (bool, error) {
-	it, err := disk.NewIterator(bucket.Key(), false)
+	it, err := disk.NewIterator(bucket.Key(), true)
 	if err != nil {
 		return false, err
 	}

blockchain/state_version_test.go

@@ -23,7 +23,7 @@ func TestValidateStateVersion(t *testing.T) {
 		seedBucket(t, testDB, db.ClassesTrie)
 
 		err := blockchain.ValidateStateVersion(testDB, true)
-		require.ErrorContains(t, err, "deprecated state")
+		require.ErrorContains(t, err, "existing state")
 		require.ErrorContains(t, err, "--new-state")
 	})
 

core/state/object.go

@@ -1,12 +1,14 @@
 package state
 
 import (
+	"errors"
 	"slices"
 
 	"github.com/NethermindEth/juno/core/felt"
 	"github.com/NethermindEth/juno/core/trie2"
 	"github.com/NethermindEth/juno/core/trie2/trienode"
 	"github.com/NethermindEth/juno/core/trie2/trieutils"
+	"github.com/NethermindEth/juno/db"
 	"golang.org/x/exp/maps"
 )
 
@@ -59,6 +61,9 @@ func (s *stateObject) getStorage(key *felt.Felt) (felt.Felt, error) {
 	// todo: remove felt cast
 	v, err := reader.Node((*felt.Address)(&s.addr), &path, nil, true)
 	if err != nil {
+		if errors.Is(err, db.ErrKeyNotFound) {
+			return felt.Zero, nil
+		}
 		return felt.Zero, err
 	}
 

node/node_test.go

@@ -94,6 +94,7 @@ func TestNetworkVerificationOnNonEmptyDB(t *testing.T) {
 				DatabasePath:                       dbPath,
 				DBCompression:                      "zstd",
 				Network:                            test.network,
+				NewState:                           statetestutils.UseNewState(),
 				DisableL1Verification:              true,
 				SubmittedTransactionsCacheEntryTTL: time.Second,
 			}, "v0.1", logLevel)