test(state): add unit tests for state accessors by Ehsan-saradar · Pull Request #3752 · NethermindEth/juno

Ehsan-saradar · 2026-06-22T08:12:32Z

Description

Adds dedicated unit tests for core/state/accessors.go, which previously had no direct coverage.

Covers:

Contract accessors (Has/Get/Write/DeleteContract): absence before write, write→read round-trip, overwrite, and delete.
Class accessors (Has/Get/Write/DeleteClass): same lifecycle, round-tripping an encoded Sierra class definition.
History accessors (nonce / class-hash / storage): writing and deleting history entries, read back through StateReader — reading at the written block, stepping back to the previous entry, returning zero before the first entry, and honouring block boundaries across two entries.
GetStateObject: not-found propagation and successful wrapping of a stored contract.

Issue

Closes #3688

Type of change

Tests

Testing

go test ./core/state/ passes locally.

Copilot

Pull request overview

Adds dedicated unit tests for core/state/accessors.go to address missing direct coverage (Issue #3688), validating basic CRUD behavior for contracts/classes and correctness of history accessors when read through StateReader.

Changes:

Adds unit tests for contract and class accessors (Has/Get/Write/Delete*).
Adds tests for nonce/class-hash/storage history accessors using StateReader historical reads.
Adds tests for GetStateObject not-found propagation and success wrapping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rodrodros · 2026-06-25T10:29:21Z

~~Closing PR, 3 days old and comments unanswered~~

My mistake, were address but not answered

Ehsan-saradar · 2026-06-25T10:42:45Z

@rodrodros all comments are fixed

codecov · 2026-06-25T11:11:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.08%. Comparing base (682a0d2) to head (dca0afe).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
+ Coverage   75.03%   75.08%   +0.05%     
==========================================
  Files         433      433              
  Lines       38594    38594              
==========================================
+ Hits        28960    28980      +20     
+ Misses       7632     7623       -9     
+ Partials     2002     1991      -11

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RafaelGranza · 2026-06-29T00:15:21Z

@Ehsan-saradar, please fix the lint errors.
You can run them locally with make lint

Ehsan-saradar · 2026-06-29T08:48:26Z

Hey @RafaelGranza, fixed the lint error in dca0afe (the long line). Ran make lint locally and it's clean now. Could you re-approve the CI run when you get a chance? Thanks!

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

RafaelGranza · 2026-06-29T11:35:10Z

+func TestGetStateObject(t *testing.T) {
+	addr := felt.NewUnsafeFromString[felt.Felt]("0x123")
+
+	t.Run("propagates not-found for a missing contract", func(t *testing.T) {
+		disk := memory.New()
+
+		_, err := state.GetStateObject(disk, nil, addr)
+		assert.ErrorIs(t, err, db.ErrKeyNotFound)
+	})
+}


This one is a fair test. It does not test the fields are equal, yet it tests that the thing was stored, no errors and that the obj was not nil.

RafaelGranza · 2026-06-29T11:38:46Z

+	t.Run("delete removes the class", func(t *testing.T) {
+		disk := memory.New()
+		require.NoError(t, state.WriteClass(disk, classHash, newClass()))
+
+		require.NoError(t, state.DeleteClass(disk, classHash))
+
+		exists, err := state.HasClass(disk, classHash)
+		require.NoError(t, err)
+		assert.False(t, exists)
+
+		_, err = state.GetClass(disk, classHash)
+		assert.ErrorIs(t, err, db.ErrKeyNotFound)
+	})


Adds dedicated unit tests for core/state/accessors.go. Closes NethermindEth#3688

Give each subtest its own StateDB (and StateReader for history) so they no longer share mutable state or depend on execution order. Rename the contract-writing helper to storeContract to avoid shadowing the package-level writeContract function.

Move accessors_test.go to package state_test so it compiles against the exported accessors only, instead of reaching into unexported internals (stateDB.disk, newTestStateDB). Contract/class tests now write through a plain memory store, and history tests build a StateDB/StateReader via the exported constructors. Drop the "wraps the stored contract on success" case from TestGetStateObject: it only asserted, via unexported fields, that the constructor copied its inputs (a tautological test). The not-found case, which is the actual behavior of GetStateObject, is kept.

RafaelGranza

Please take a look at the copilot comments.

Copilot AI review requested due to automatic review settings June 22, 2026 08:12

Copilot started reviewing on behalf of Ehsan-saradar June 22, 2026 08:13 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread core/state/accessors_test.go

Comment thread core/state/accessors_test.go

Comment thread core/state/accessors_test.go

Ehsan-saradar force-pushed the test/state-accessors-tests branch from c13deef to 24e1f7f Compare June 22, 2026 11:59

rodrodros closed this Jun 25, 2026

rodrodros reopened this Jun 25, 2026

RafaelGranza reviewed Jun 25, 2026

View reviewed changes

Comment thread core/state/accessors_test.go Outdated

Comment thread core/state/accessors_test.go Outdated

Comment thread core/state/accessors_test.go

RafaelGranza force-pushed the test/state-accessors-tests branch from 6a35f50 to b2230fa Compare June 26, 2026 11:27

Ehsan-saradar force-pushed the test/state-accessors-tests branch from b74eedb to 365cedf Compare June 27, 2026 05:44

Ehsan-saradar requested a review from RafaelGranza June 28, 2026 09:37

Ehsan-saradar requested a review from Copilot June 29, 2026 10:15

Copilot started reviewing on behalf of Ehsan-saradar June 29, 2026 10:22 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Ehsan-saradar added 4 commits June 29, 2026 08:27

test(state): add unit tests for state accessors

889b22d

Adds dedicated unit tests for core/state/accessors.go. Closes NethermindEth#3688

test(state): wrap long func signature to satisfy lll linter

eb9787a

RafaelGranza force-pushed the test/state-accessors-tests branch from dca0afe to eb9787a Compare June 29, 2026 11:27

RafaelGranza reviewed Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

Ehsan-saradar commented Jun 22, 2026

Description

Issue

Type of change

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rodrodros commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ehsan-saradar commented Jun 25, 2026

Uh oh!

codecov Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RafaelGranza commented Jun 29, 2026

Uh oh!

Ehsan-saradar commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

RafaelGranza Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

RafaelGranza Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

RafaelGranza left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rodrodros commented Jun 25, 2026 •

edited

Loading

codecov Bot commented Jun 25, 2026 •

edited

Loading