fix(rpc): change ExecutionError code from -32003 to -32000 to match Geth

Author: manusw7

src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.EthCall.cs

@@ -64,7 +64,7 @@ public async Task Eth_call_web3_should_return_insufficient_balance_error()
             $"{{\"from\":\"{TestAccountAddress}\",\"gasPrice\":\"0x100000\", \"data\": \"{BalanceOfCallData}\", \"to\": \"{BatTokenAddress}\", \"value\": 500, \"gas\": 1000000}}");
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction);
         JToken parsed = JToken.Parse(serialized);
-        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32003));
+        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32000));
         Assert.That(parsed["error"]!["message"]!.Value<string>(), Does.Contain("insufficient funds for gas * price + value"));
         AssertAccountDoesNotExist(ctx, TestAccount);
     }
@@ -111,7 +111,7 @@ public async Task Eth_call_no_recipient_should_work_as_init()
         string serialized =
             await ctx.Test.TestEthRpc("eth_call", transaction, "latest");
         Assert.That(
-            serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32003,\"message\":\"stack underflow\"},\"id\":67}"));
+            serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"stack underflow\"},\"id\":67}"));
     }
 
 
@@ -334,7 +334,7 @@ public async Task Eth_call_with_value_transfer_without_from_address_should_throw
             $"{{\"type\": \"0x2\", \"value\":\"{1.Ether}\", \"data\": \"{dataStr}\"}}");
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction);
         JToken parsed = JToken.Parse(serialized);
-        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32003));
+        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32000));
         Assert.That(parsed["error"]!["message"]!.Value<string>(), Does.Contain("insufficient funds for gas * price + value"));
     }
 
@@ -498,7 +498,7 @@ public async Task Eth_call_uses_gas_cap_when_not_specified()
             $"{{\"from\": \"{SecondaryTestAddress}\", \"data\": \"{InfiniteLoopCode.ToHexString(true)}\"}}");
 
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction);
-        Assert.That(JToken.Parse(serialized), Is.EqualTo(JToken.Parse($"{{\"jsonrpc\":\"2.0\",\"error\":{{\"code\":-32003,\"message\":\"out of gas\"}},\"id\":67}}")).Using(JToken.EqualityComparer));
+        Assert.That(JToken.Parse(serialized), Is.EqualTo(JToken.Parse($"{{\"jsonrpc\":\"2.0\",\"error\":{{\"code\":-32000,\"message\":\"out of gas\"}},\"id\":67}}")).Using(JToken.EqualityComparer));
     }
 
     [Test]
@@ -821,7 +821,7 @@ public async Task Eth_call_bubbles_up_precompile_errors()
 
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction);
 
-        Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32003,\"message\":\"Precompile MODEXP failed with error: one or more of base/exponent/modulus length exceeded 1024 bytes\"},\"id\":67}"));
+        Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"Precompile MODEXP failed with error: one or more of base/exponent/modulus length exceeded 1024 bytes\"},\"id\":67}"));
     }
 
     [TestCase("""{"input":"0x23e52","gasPrice":"0x1"}""", TestName = "Legacy tx odd-length input")]
@@ -854,7 +854,7 @@ private static async Task TestEthCallOutOfGas(Context ctx, ulong? specifiedGasLi
             $"{{\"from\": \"{SecondaryTestAddress}\"{gasParam}, \"data\": \"{InfiniteLoopCode.ToHexString(true)}\"}}");
 
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction);
-        Assert.That(JToken.Parse(serialized), Is.EqualTo(JToken.Parse($"{{\"jsonrpc\":\"2.0\",\"error\":{{\"code\":-32003,\"message\":\"out of gas\"}},\"id\":67}}")).Using(JToken.EqualityComparer));
+        Assert.That(JToken.Parse(serialized), Is.EqualTo(JToken.Parse($"{{\"jsonrpc\":\"2.0\",\"error\":{{\"code\":-32000,\"message\":\"out of gas\"}},\"id\":67}}")).Using(JToken.EqualityComparer));
     }
 
     // Each test uses a state override to inject one-opcode contract code at the target address,
@@ -1013,7 +1013,7 @@ public async Task Eth_call_setCode_invalid_transaction_returns_error(string txJs
         string serialized = await ctx.Test.TestEthRpc("eth_call", transaction, "latest");
 
         JToken parsed = JToken.Parse(serialized);
-        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32003));
+        Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32000));
         Assert.That(parsed["error"]!["message"]!.Value<string>(), Does.Contain(expectedMessage));
     }
 
@@ -1067,7 +1067,7 @@ public async Task Eth_call_zero_balance_reports_full_required_balance(
 
         using (Assert.EnterMultipleScope())
         {
-            Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32003));
+            Assert.That(parsed["error"]!["code"]!.Value<int>(), Is.EqualTo(-32000));
             Assert.That(message, Does.Contain("insufficient funds for gas * price + value"));
             Assert.That(message, Does.Contain(expectedDetailSubstring));
         }

src/Nethermind/Nethermind.JsonRpc/ErrorCodes.cs

@@ -45,7 +45,7 @@ public static class ErrorCodes
         /// <summary>
         /// EVM execution error (out of gas, insufficient funds during execution, etc.)
         /// </summary>
-        public const int ExecutionError = -32003;
+        public const int ExecutionError = -32000;
 
         /// <summary>
         /// Requested resource not found

src/Nethermind/Nethermind.Runner.Test/JsonRpc/StartupTests.cs

@@ -281,7 +281,7 @@ public async Task HttpJsonRpcResponseSink_OmitsNullErrorData()
             Error = new Error { Code = ErrorCodes.ExecutionError, Message = "out of gas" }
         });
 
-        Assert.That(response, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32003,\"message\":\"out of gas\"},\"id\":1}"));
+        Assert.That(response, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"out of gas\"},\"id\":1}"));
     }
 
     [Test]