feat: relay server missing features (#354)

* feat(relay-server): finish relay server implementation

- Start Prometheus monitoring server on configured monitoring_addr
- Handle relay swarm events: ReservationReqAccepted/Denied, ReservationTimedOut,
  CircuitReqAccepted/Denied, CircuitClosed — with structured logging
- Track connection metrics (connection_total, active_connections) via RELAY_METRICS
  on SwarmEvent::ConnectionEstablished and ConnectionClosed
- Log version, git hash, and build time on startup using pluto_core::version
- Make RelayMetrics fields public; add PeerWithPeerClusterLabels::new() constructor
- Remove #[allow(missing_docs)] from p2p.rs; add module doc comment
- Add vise-exporter to regular (non-dev) dependencies
- Update serve_addr_metrics test: remove #[ignore], test monitoring endpoint,
  check for prometheus output

Closes #129

Co-authored-by: Bohdan Ohorodnii <varex83@users.noreply.github.com>

* fix(relay-server): fix compilation and formatting errors in p2p.rs

- Dereference LazyLock for VERSION in tracing macro: %*VERSION
- Use inc_by(1)/dec_by(1) instead of inc()/dec() on vise::Gauge
- Add .. to ReservationReqDenied and CircuitReqDenied patterns for missing status field
- Merge pluto_p2p imports and reorder metrics imports alphabetically
- Reformat ListenerClosed, ReservationReqAccepted, ReservationReqDenied match arms per rustfmt

Co-authored-by: Bohdan Ohorodnii <varex83@users.noreply.github.com>

* chore: merge main (feat: add bootnode.rs #262)

Manually merges changes from main branch commit e41e6d9:
- Add crates/p2p/src/bootnode.rs and crates/p2p/src/relay.rs
- Add crates/p2p/examples/bootnode.rs
- Update p2p peer.rs: add Default for MutablePeer, addr_infos_from_p2p_addrs
- Update p2p gater.rs: remove Arc wrapper from relay peers
- Update p2p utils.rs: add multi_addrs_via_relay helper
- Update p2p lib.rs: export bootnode and relay modules
- Update p2p Cargo.toml: add backon, reqwest, url deps
- Fix crypto share indexing: use 1-indexed keys throughout
- Remove MathError enum, replace with direct DivisionByZero variant
- Fix cluster test_cluster.rs: use 1-indexed share lookup
- Fix app obolapi: add FailedToConvertShareIndexToU8/MathOverflow errors
- Add app/src/utils.rs with archive helpers
- Add core/src/parasigdb/memory.rs
- Update Cargo.toml and Cargo.lock with flate2, tar deps
- Update relay_server example: simplify TCP addr, add docblock

Co-authored-by: Bohdan Ohorodnii <varex83@users.noreply.github.com>

* chore: merge main (feat(core): implement signeddata #273)

Manual merge of 4e68ef9 into this branch (shallow clone prevents git merge).

- Add crates/core/src/signeddata.rs and signeddata testdata
- Add pub mod signeddata to crates/core/src/lib.rs
- Update crates/core/Cargo.toml with signeddata deps
- Update crates/crypto/Cargo.toml: remove pluto-core dep (avoids cycle)
- Update crates/crypto/src/tblsconv.rs: remove core conversions (avoids cycle)
- Add/update crates/eth2api/ spec types for signeddata
- Add/update crates/eth2util/src/types.rs
- Update Cargo.lock

Co-authored-by: Lautaro Emanuel <emlautarom1@users.noreply.github.com>

* fixed compilation and clippy

* review

* retry_get helper for unit tests

* better assertions in the serve_addr_metrics test

* removed unsed ssz_types.rs

* move back multi_addrs_via_relay

* Bandwidth metric for the p2p relay server

* Unit tests for bandwidth metric

* Comments added

* fixed clippy

* moved metrics into RelayMetrics

* review comments

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Bohdan Ohorodnii <varex83@users.noreply.github.com>
Co-authored-by: Lautaro Emanuel <emlautarom1@users.noreply.github.com>

Author: 4 people

Cargo.lock

@@ -66,6 +66,7 @@ aes = "0.8.4"
 ctr = "0.9.2"
 cipher = "0.4.4"
 pbkdf2 = "0.12.2"
+pin-project = "1"
 sha2 = "0.10.9"
 scrypt = "0.11.0"
 unicode-normalization = "0.1.25"

Cargo.toml

@@ -415,17 +415,29 @@ mod tests {
     }
 
     #[tokio::test]
-    #[ignore = "/metrics endpoint not implemented"]
     async fn serve_addr_metrics() {
+        let monitoring_addr = net::TcpListener::bind("127.0.0.1:0")
+            .await
+            .unwrap()
+            .local_addr()
+            .unwrap()
+            .to_string();
+        let monitoring_url = format!("http://{monitoring_addr}/metrics");
+
         with_relay_server(
-            |_| {},
-            async |cfg| {
-                let response = relay_server_get(cfg, "/metrics").await.unwrap();
+            move |args| {
+                args.debug_monitoring.monitor_addr = Some(monitoring_addr);
+            },
+            async move |_cfg| {
+                let response = retry_get(&monitoring_url).await.unwrap();
                 let body = response.text().await.unwrap();
 
-                dbg!(&body);
-
-                assert!(body.contains("libp2p_relaysvc_"));
+                assert!(body.contains("relay_p2p_connection_total"));
+                assert!(body.contains("relay_p2p_active_connections"));
+                assert!(body.contains("relay_p2p_ping_latency"));
+                assert!(body.contains("relay_p2p_network_sent_bytes"));
+                assert!(body.contains("relay_p2p_network_receive_bytes"));
+                assert!(body.ends_with("# EOF\n"));
             },
         )
         .await
@@ -523,12 +535,11 @@ mod tests {
         path: &str,
     ) -> Result<reqwest::Response, reqwest::Error> {
         let http_address = cfg.http_addr.unwrap();
-        let request = async || {
-            reqwest::get(format!("http://{}{}", http_address, path))
-                .await
-                .and_then(|r| r.error_for_status())
-        };
+        retry_get(&format!("http://{}{}", http_address, path)).await
+    }
 
+    async fn retry_get(url: &str) -> Result<reqwest::Response, reqwest::Error> {
+        let request = async || reqwest::get(url).await.and_then(|r| r.error_for_status());
         let mut backoff = backon::ExponentialBuilder::default()
             .with_min_delay(time::Duration::from_millis(200))
             .with_max_delay(time::Duration::from_secs(2))

crates/cli/src/commands/relay.rs

@@ -701,6 +701,7 @@ mod tests {
                 NodeType::TCP,
                 false,
                 p2p_context.clone(),
+                None,
                 move |builder, _keypair| builder.with_inner(behaviour),
             )?;
             let addr: Multiaddr = format!("/ip4/127.0.0.1/tcp/{}", ports[index]).parse()?;

crates/dkg/src/bcast/behaviour.rs

@@ -434,6 +434,7 @@ mod tests {
                 NodeType::TCP,
                 false,
                 p2p_context,
+                None,
                 move |builder, _key| builder.with_inner(behaviour),
             )?;
 

crates/dkg/src/exchanger.rs

@@ -570,6 +570,7 @@ mod tests {
                 NodeType::TCP,
                 false,
                 p2p_context,
+                None,
                 move |builder, _| builder.with_inner(behaviour),
             )?;
 

crates/dkg/src/nodesigs.rs

@@ -28,6 +28,7 @@ serde.workspace = true
 serde_json.workspace = true
 pluto-core.workspace = true
 backon.workspace = true
+pin-project.workspace = true
 reqwest.workspace = true
 unsigned-varint.workspace = true
 url.workspace = true