refactor: avoid double hash

Author: iamquang95

crates/dkg/examples/sync.rs

@@ -155,10 +155,7 @@ impl ClusterInfo {
 
     fn peer_label(&self, peer_id: &PeerId) -> String {
         match self.indices.get(peer_id) {
-            Some(index) => format!(
-                "node={} peer_id={peer_id}",
-                index.checked_add(1).unwrap_or(*index)
-            ),
+            Some(index) => format!("node={} peer_id={peer_id}", index.saturating_add(1)),
             None => format!("peer_id={peer_id}"),
         }
     }

crates/dkg/src/sync/handler.rs

@@ -286,10 +286,6 @@ impl ConnectionHandler for Handler {
                 self.outbound = OutboundState::Running(run_outbound_stream(client, stream).boxed());
             }
             ConnectionEvent::DialUpgradeError(error) => self.on_dial_upgrade_error(error),
-            ConnectionEvent::AddressChange(_)
-            | ConnectionEvent::LocalProtocolsChange(_)
-            | ConnectionEvent::RemoteProtocolsChange(_) => {}
-            ConnectionEvent::ListenUpgradeError(_) => {}
             _ => {}
         }
     }

crates/dkg/src/sync/server.rs

@@ -211,9 +211,12 @@ impl Server {
     }
 
     pub(crate) async fn update_step(&self, peer_id: PeerId, step: i64) -> Result<bool> {
+        use std::collections::hash_map::Entry;
+
         let mut state = self.inner.state.write().await;
-        match state.steps.get(&peer_id).copied() {
-            Some(current) => {
+        match state.steps.entry(peer_id) {
+            Entry::Occupied(mut entry) => {
+                let current = *entry.get();
                 if step < current {
                     return Err(Error::PeerStepBehind);
                 }
@@ -226,14 +229,18 @@ impl Server {
                 if step == current {
                     return Ok(false);
                 }
+
+                entry.insert(step);
             }
-            None if !(0..=1).contains(&step) => {
-                return Err(Error::AbnormalInitialStep);
+            Entry::Vacant(entry) => {
+                if !(0..=1).contains(&step) {
+                    return Err(Error::AbnormalInitialStep);
+                }
+
+                entry.insert(step);
             }
-            None => {}
         }
 
-        state.steps.insert(peer_id, step);
         self.inner.notify.notify_waiters();
         Ok(true)
     }