feat: add eth2wrap/valcache#122
Merged
Merged
Conversation
- Avoids parsing on each request
- Prevents VSCode from rebuilding everything during tests
- Makes it easier to use `String` and `str` at the same time
- Redices boilerplate when dealing with the `eth2api` lib - Use `eth2api` types in `valcache`
- Remove redundant code - Use `From` for `PoisonError` - Code cleanup
- Prefer `GetStateValidatorsResponseResponseDatum` over custom `Validator`
- Make them closer to the original implementation
Contributor
|
Coverage (base → head): |
- Useful for mocking requests/responses in tests
- Use `POST` endpoint since reqwest cannot deal with complex query params - Use `wiremock` to fake an HTTP server
- Beacon should be called once
- Superseded by Go tests
emlautarom1
commented
Jan 15, 2026
| std::fs::remove_file("src/mod.rs")?; | ||
|
|
||
| // Ensure all structs have both Serialize and Deserialize derives | ||
| ensure_serde_derives("src/types.rs")?; |
Collaborator
Author
There was a problem hiding this comment.
We need to have both Serialize and Deserialize in order to mock Beacon client responses.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements the eth2wrap/valcache module as part of the broader eth2wrap implementation (issue #60). The PR adds a validator cache that stores active and complete validator information for the current epoch, with the ability to refresh by head or by slot with fallback functionality.
Changes:
- Added
valcachemodule with caching for validator information from beacon nodes - Added helper types and extensions in
eth2apimodule for working with validator data - Modified
eth2apibuild script to automatically addSerializederives alongsideDeserializefor test mocking - Changed
PubKey::TryFromimplementation fromStringto&strfor better ergonomics
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| flake.nix | Added RUSTC_BOOTSTRAP = "1" environment variable for Nix dev shell |
| crates/eth2api/build.rs | Added regex-based post-processing to ensure Serialize derives are present |
| crates/eth2api/Cargo.toml | Added regex as build dependency |
| crates/charon/src/lib.rs | Added eth2wrap module with documentation |
| crates/charon/src/eth2wrap/version.rs | Beacon node version validation implementation |
| crates/charon/src/eth2wrap/valcache.rs | Validator cache implementation with comprehensive tests using wiremock |
| crates/charon/src/eth2wrap/mod.rs | Module declarations for eth2wrap components |
| crates/charon/src/eth2wrap/eth2api.rs | Helper types and trait extensions for eth2api |
| crates/charon/Cargo.toml | Added dependencies for eth2api, anyhow, regex, and wiremock |
| crates/charon-core/src/types.rs | Changed PubKey TryFrom implementation from String to &str |
| Cargo.toml | Added wiremock dev dependency and moved regex to appropriate position |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Hold lock across awaits - Match the original Go implementation - Simplify internals
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iamquang95
reviewed
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #152
Requires #121
There are some small differences to reduce the amount of time spent with a mutex being held.
For testing I've decided to use
wiremockbut I'm open to suggestions on alternative testing approaches.Note that by exercising the actual network requests I found out that some
GETendpoints cannot be used sincereqwest(the underlying HTTP client forEthBeaconNodeApiClient) has troubles building URLs with query parameters.