feat: add support for cluster definition v1.10.0 #20
Merged
Conversation
…and SignedDataSet
…ry_from implementation
…erialization/deserialization tests
…Eth/charon-rs into bohdan/add-core-types
- Added `thiserror` dependency for improved error handling. - Introduced `blsful` module for TBLS implementation. - Refactored `tbls` module to utilize new types and error handling. - Created `tblsconv` module for type conversions between byte slices and cryptographic types. - Removed the old `herumi` implementation and replaced it with the new `blsful` based implementation. - Added utility functions for key and signature conversions. - Updated types and error definitions for better clarity and consistency.
- Reformatted comments for better readability. - Adjusted spacing and alignment in error messages for consistency. - Ensured clarity in documentation regarding expected byte lengths for key and signature conversions.
…anizing workspace lints
…ignatures - Updated dependencies in Cargo.toml and Cargo.lock to use the blst library. - Removed blsful module and its associated code, including type conversions and utility functions. - Introduced a new blst_impl module for the BLST implementation of threshold BLS signatures. - Refactored tbls module to utilize the new blst implementation. - Cleaned up error handling and types to align with the new library. - Added workspace lints and improved documentation throughout the codebase.
emlautarom1
approved these changes
Nov 6, 2025
emlautarom1
left a comment
emlautarom1
left a comment
Collaborator
There was a problem hiding this comment.
Minor things, LGTM.
| /// Timestamp is the human-readable timestamp of this definition. Max 32 | ||
| /// chars. Note that this was added in v1.1.0, so may be empty for older | ||
| /// versions. | ||
| pub timestamp: DateTime<Utc>, |
Collaborator
There was a problem hiding this comment.
Since this field was added later we should make it optional:
Suggested change
| pub timestamp: DateTime<Utc>, | |
| pub timestamp: Option<DateTime<Utc>>, |
Collaborator
Author
There was a problem hiding this comment.
In ssz PR it's made as a raw string + added method to retrieve the timestamp in DateTime<Utc> format. This was done to not edit formatting of the timestamp, since it could affect the ssz hashing.
Comment on lines
+1
to
+2
| // Copyright © 2022-2025 Obol Labs Inc. Licensed under the terms of a Business | ||
| // Source License 1.1 |
Collaborator
There was a problem hiding this comment.
Remove the original Obol license
emlautarom1
approved these changes
Nov 27, 2025
emlautarom1
left a comment
emlautarom1
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but needs to be rebased with main due to charon-crypto diffs.
Contributor
|
Coverage (base → head): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the #16. It adds support for cluster definition v1.10.0, together with some foundational types. This PR should be merged after #19