Skip to content

refactor: improve deadliner api #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
therustmonk wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: improve deadliner api #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2fce2b
Improve the deadline api
therustmonk May 22, 2026
53f0d7c
Add outcomes
therustmonk May 22, 2026
207827d
Remove the deadliner trait
therustmonk May 22, 2026
0e1f3b6
Fix docs
therustmonk May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/core/src/deadline/calculator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,17 @@ pub trait DeadlineCalculator: Send + Sync + 'static {
fn deadline(&self, duty: &Duty) -> Result<Option<DateTime<Utc>>>;
}

/// Calculator that reports every duty as never expiring. Useful for
/// scenarios that need to plug into the deadliner API but don't actually want
/// any eviction (e.g. DKG, which is one-shot and outside the slot timeline).
pub struct NeverExpiringCalculator;

impl DeadlineCalculator for NeverExpiringCalculator {
fn deadline(&self, _duty: &Duty) -> Result<Option<DateTime<Utc>>> {
Ok(None)
}
}

impl DeadlineCalculator for DutyDeadlineCalculator {
fn deadline(&self, duty: &Duty) -> Result<Option<DateTime<Utc>>> {
if duty.duty_type.never_expires() {
Expand Down
Loading
Loading