-
Notifications
You must be signed in to change notification settings - Fork 144
Format code with clang-format v19 #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,203 @@ | ||
| # Basic .clang-format taken from FreeBSD | ||
| --- | ||
| BasedOnStyle: WebKit | ||
| AlignAfterOpenBracket: DontAlign | ||
| AlignConsecutiveMacros: AcrossEmptyLines | ||
| AlignConsecutiveAssignments: false | ||
| AlignConsecutiveDeclarations: false | ||
| AlignEscapedNewlines: Left | ||
| AlignOperands: false | ||
| AlignTrailingComments: true | ||
| AllowAllArgumentsOnNextLine: false | ||
| AllowAllParametersOfDeclarationOnNextLine: false | ||
| AllowShortBlocksOnASingleLine: Never | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowShortFunctionsOnASingleLine: InlineOnly | ||
| AllowShortIfStatementsOnASingleLine: Never | ||
| AllowShortLoopsOnASingleLine: false | ||
| AlwaysBreakAfterReturnType: TopLevelDefinitions | ||
| AlwaysBreakBeforeMultilineStrings: false | ||
| AlwaysBreakTemplateDeclarations: MultiLine | ||
| BinPackArguments: true | ||
| BinPackParameters: true | ||
| BreakBeforeBinaryOperators: None | ||
| BreakBeforeBraces: WebKit | ||
| BreakBeforeTernaryOperators: false | ||
| # TODO: BreakStringLiterals can cause very strange formatting so turn it off? | ||
| BreakStringLiterals: false | ||
| # Prefer: | ||
| # some_var = function(arg1, | ||
| # arg2) | ||
| # over: | ||
| # some_var = | ||
| # function(arg1, arg2) | ||
| PenaltyBreakAssignment: 100 | ||
| # Prefer: | ||
| # some_long_function(arg1, arg2 | ||
| # arg3) | ||
| # over: | ||
| # some_long_function( | ||
| # arg1, arg2, arg3) | ||
| PenaltyBreakBeforeFirstCallParameter: 100 | ||
| CompactNamespaces: true | ||
| DerivePointerAlignment: false | ||
| DisableFormat: false | ||
| ForEachMacros: | ||
| - ARB_ARRFOREACH | ||
| - ARB_ARRFOREACH_REVWCOND | ||
| - ARB_ARRFOREACH_REVERSE | ||
| - ARB_FOREACH | ||
| - ARB_FOREACH_FROM | ||
| - ARB_FOREACH_SAFE | ||
| - ARB_FOREACH_REVERSE | ||
| - ARB_FOREACH_REVERSE_FROM | ||
| - ARB_FOREACH_REVERSE_SAFE | ||
| - BIT_FOREACH_ISCLR | ||
| - BIT_FOREACH_ISSET | ||
| - CPU_FOREACH | ||
| - CPU_FOREACH_ISCLR | ||
| - CPU_FOREACH_ISSET | ||
| - FOREACH_THREAD_IN_PROC | ||
| - FOREACH_PROC_IN_SYSTEM | ||
| - FOREACH_PRISON_CHILD | ||
| - FOREACH_PRISON_DESCENDANT | ||
| - FOREACH_PRISON_DESCENDANT_LOCKED | ||
| - FOREACH_PRISON_DESCENDANT_LOCKED_LEVEL | ||
| - MNT_VNODE_FOREACH_ALL | ||
| - MNT_VNODE_FOREACH_ACTIVE | ||
| - RB_FOREACH | ||
| - RB_FOREACH_FROM | ||
| - RB_FOREACH_SAFE | ||
| - RB_FOREACH_REVERSE | ||
| - RB_FOREACH_REVERSE_FROM | ||
| - RB_FOREACH_REVERSE_SAFE | ||
| - SLIST_FOREACH | ||
| - SLIST_FOREACH_FROM | ||
| - SLIST_FOREACH_FROM_SAFE | ||
| - SLIST_FOREACH_SAFE | ||
| - SLIST_FOREACH_PREVPTR | ||
| - SPLAY_FOREACH | ||
| - LIST_FOREACH | ||
| - LIST_FOREACH_FROM | ||
| - LIST_FOREACH_FROM_SAFE | ||
| - LIST_FOREACH_SAFE | ||
| - STAILQ_FOREACH | ||
| - STAILQ_FOREACH_FROM | ||
| - STAILQ_FOREACH_FROM_SAFE | ||
| - STAILQ_FOREACH_SAFE | ||
| - TAILQ_FOREACH | ||
| - TAILQ_FOREACH_FROM | ||
| - TAILQ_FOREACH_FROM_SAFE | ||
| - TAILQ_FOREACH_REVERSE | ||
| - TAILQ_FOREACH_REVERSE_FROM | ||
| - TAILQ_FOREACH_REVERSE_FROM_SAFE | ||
| - TAILQ_FOREACH_REVERSE_SAFE | ||
| - TAILQ_FOREACH_SAFE | ||
| - VM_MAP_ENTRY_FOREACH | ||
| - VM_PAGE_DUMP_FOREACH | ||
| SpaceBeforeParens: ControlStatementsExceptForEachMacros | ||
| IndentCaseLabels: false | ||
| IndentPPDirectives: None | ||
| Language: Cpp | ||
| NamespaceIndentation: None | ||
| PointerAlignment: Right | ||
| ContinuationIndentWidth: 4 | ||
| IndentWidth: 8 | ||
| TabWidth: 8 | ||
| ColumnLimit: 80 | ||
| UseTab: Always | ||
| SpaceAfterCStyleCast: false | ||
| IncludeBlocks: Regroup | ||
| IncludeCategories: | ||
| - Regex: '^\"opt_.*\.h\"' | ||
| Priority: 1 | ||
| SortPriority: 10 | ||
| - Regex: '^<sys/cdefs\.h>' | ||
| Priority: 2 | ||
| SortPriority: 20 | ||
| - Regex: '^<sys/types\.h>' | ||
| Priority: 2 | ||
| SortPriority: 21 | ||
| - Regex: '^<sys/param\.h>' | ||
| Priority: 2 | ||
| SortPriority: 22 | ||
| - Regex: '^<sys/systm\.h>' | ||
| Priority: 2 | ||
| SortPriority: 23 | ||
| - Regex: '^<sys.*/' | ||
| Priority: 2 | ||
| SortPriority: 24 | ||
| - Regex: '^<vm/vm\.h>' | ||
| Priority: 3 | ||
| SortPriority: 30 | ||
| - Regex: '^<vm/' | ||
| Priority: 3 | ||
| SortPriority: 31 | ||
| - Regex: '^<machine/' | ||
| Priority: 4 | ||
| SortPriority: 40 | ||
| - Regex: '^<(x86|amd64|i386|xen)/' | ||
| Priority: 5 | ||
| SortPriority: 50 | ||
| - Regex: '^<dev/' | ||
| Priority: 6 | ||
| SortPriority: 60 | ||
| # Most BSD require <netinet/in.h> before this ... | ||
| - Regex: '^<netinet/if_ether.h>' | ||
| Priority: 7 | ||
| SortPriority: 71 | ||
| - Regex: '^<net.*/' | ||
| Priority: 7 | ||
| SortPriority: 70 | ||
| - Regex: '^<protocols/' | ||
| Priority: 7 | ||
| SortPriority: 72 | ||
| - Regex: '^<(fs|nfs(|client|server)|ufs)/' | ||
| Priority: 8 | ||
| SortPriority: 80 | ||
| - Regex: '^<[^/].*\.h' | ||
| Priority: 9 | ||
| SortPriority: 90 | ||
| - Regex: '^\".*\.h\"' | ||
| Priority: 10 | ||
| SortPriority: 100 | ||
| # LLVM's header include ordering style is almost the exact opposite of ours. | ||
| # Unfortunately, they have hard-coded their preferences into clang-format. | ||
| # Clobbering this regular expression to avoid matching prevents non-system | ||
| # headers from being forcibly moved to the top of the include list. | ||
| # http://llvm.org/docs/CodingStandards.html#include-style | ||
| IncludeIsMainRegex: 'BLAH_DONT_MATCH_ANYTHING' | ||
| SortIncludes: true | ||
| KeepEmptyLinesAtTheStartOfBlocks: false | ||
| TypenameMacros: | ||
| - ARB_ELMTYPE | ||
| - ARB_HEAD | ||
| - ARB8_HEAD | ||
| - ARB16_HEAD | ||
| - ARB32_HEAD | ||
| - ARB_ENTRY | ||
| - ARB8_ENTRY | ||
| - ARB16_ENTRY | ||
| - ARB32_ENTRY | ||
| - LIST_CLASS_ENTRY | ||
| - LIST_CLASS_HEAD | ||
| - LIST_ENTRY | ||
| - LIST_HEAD | ||
| - QUEUE_TYPEOF | ||
| - RB_ENTRY | ||
| - RB_HEAD | ||
| - SLIST_CLASS_HEAD | ||
| - SLIST_CLASS_ENTRY | ||
| - SLIST_HEAD | ||
| - SLIST_ENTRY | ||
| - SMR_POINTER | ||
| - SPLAY_ENTRY | ||
| - SPLAY_HEAD | ||
| - STAILQ_CLASS_ENTRY | ||
| - STAILQ_CLASS_HEAD | ||
| - STAILQ_ENTRY | ||
| - STAILQ_HEAD | ||
| - TAILQ_CLASS_ENTRY | ||
| - TAILQ_CLASS_HEAD | ||
| - TAILQ_ENTRY | ||
| - TAILQ_HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Disable DeprecatedOrUnsafeBufferHandling - our use of these is fine | ||
| # and musl does not support the the _s variants. | ||
| # Disable valist due to clang-tidy bug fixed in v19? | ||
| Checks: "cert-*,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,-clang-analyzer-valist.Uninitialized" | ||
| HeaderFilterRegex: ".*" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| If: | ||
| PathMatch: src/dev/.*\.c | ||
| CompileFlags: | ||
| Add: [-I.., -I../.., -I../../compat] | ||
| Add: [-I.., -I../.., -I../../compat, -I../../vendor] | ||
| --- | ||
| If: | ||
| PathMatch: src/.*\.c | ||
| PathMatch: src/.*\.(c|h) | ||
| CompileFlags: | ||
| Add: [-I.., -I../compat] | ||
| Add: [-I.., -I../compat, -I../vendor] | ||
| --- | ||
| CompileFlags: | ||
| Add: [-DINET, -DARP, -DARPING, -DIPV4LL, -DINET6, -DDHCP6, -DPLUGIN_DEV, -DAUTH, -DPRIVSEP] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-enable BSD CI as non-blocking instead of fully commenting it out.
Commenting out
openbsd,freebsd, andnetbsdremoves all BSD regression signal; from this point, BSD breakage can merge unnoticed. Keep these jobs runnable but non-blocking (continue-on-error: true) and/or move them to a scheduled/manual workflow if they’re currently flaky.Suggested direction
Apply the same pattern to
freebsdandnetbsd, and remove the large commented blocks once moved.🤖 Prompt for AI Agents