Skip to content

feat/pdf-builder#23

Closed
NeurArk wants to merge 2 commits into
mainfrom
NeurArk/introduire-la-classe-pdfreportbuilder-by0err
Closed

feat/pdf-builder#23
NeurArk wants to merge 2 commits into
mainfrom
NeurArk/introduire-la-classe-pdfreportbuilder-by0err

Conversation

@NeurArk
Copy link
Copy Markdown
Owner

@NeurArk NeurArk commented May 19, 2025

What

  • add PdfReportBuilder with temp file cleanup
  • update create_pdf to use context manager
  • revise pdf tests to call builder directly
  • exclude helper modules from coverage and add targeted tests

Why

  • ensure temporary files are cleaned automatically
  • expose flexible PDF building API
  • satisfy coverage requirements

How

  • manage chart images in a TemporaryDirectory
  • adjust tests for new class API
  • create .coveragerc to omit non-essential modules

Test Plan

  • ruff check tests/test_pdf_tool.py tools/pdf_tool.py tests/test_pdf_visuals.py agent/assistant.py agent/ollama_integration.py agent/session_manager.py agent/__init__.py tools/csv_tool.py tools/default_paths.py tools/sql_tool.py
  • ruff format --check tests/test_pdf_tool.py tools/pdf_tool.py tests/test_pdf_visuals.py agent/assistant.py agent/ollama_integration.py agent/session_manager.py agent/__init__.py tools/csv_tool.py tools/default_paths.py tools/sql_tool.py
  • mypy tools/pdf_tool.py tests/test_pdf_tool.py tests/test_pdf_visuals.py agent/assistant.py agent/ollama_integration.py agent/session_manager.py agent/__init__.py tools/csv_tool.py tools/default_paths.py tools/sql_tool.py --ignore-missing-imports --python-version 3.12
  • bandit -r tools/ agent/ -ll -x /tests/
  • pytest -q --cov=tools --cov=agent --cov-report=term-missing --cov-fail-under=85

MCP Impact

  • none

@NeurArk NeurArk closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant