fix: notify daemon when recording is stopped remotely#641
Open
muneebneura wants to merge 1 commit into
Open
Conversation
muneebneura
added
the
version:patch
muneebneura
force-pushed
the
fix/stop-recording-web
branch
from
8de6d20 to
1097bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recording is stopped from the web frontend, we were never draining data streams or notifying the data daemon, so recordings were never finalized or uploaded. The bug was introduced when the data daemon was updated to use a shared ring buffer transport that requires an explicit stop IPC with sequence number cutoffs in this pr: NCP-695
Bugfixes
Items