Skip to content

fix: retry transient backend errors across storage handlers and metric sync#773

Open
aditya-neuraco wants to merge 1 commit into
mainfrom
fix/retry-transient-backend-errors
Open

fix: retry transient backend errors across storage handlers and metric sync#773
aditya-neuraco wants to merge 1 commit into
mainfrom
fix/retry-transient-backend-errors

Conversation

@aditya-neuraco

Copy link
Copy Markdown
Contributor

No description provided.

@aditya-neuraco aditya-neuraco added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Jul 8, 2026
@aditya-neuraco aditya-neuraco self-assigned this Jul 8, 2026
@aditya-neuraco aditya-neuraco force-pushed the fix/retry-transient-backend-errors branch from 925169b to 9d4cee9 Compare July 8, 2026 13:24
@aditya-neuraco aditya-neuraco marked this pull request as ready for review July 8, 2026 13:24
@damonhayhurst-neuraco

Copy link
Copy Markdown
Contributor

I find this confusing.

  1. The consts you've added in core imply that we retry on these status calls for all backend api calls.
  2. The redirection away from thread_local_session() leads to a misleading read.
  3. You've localised some retry mechanisms to a locally named mixin that should really be generic.

My suggestion would be to extend thread_local_session() with retry mechanisms that can be overriden when necessary.

@aditya-neuraco aditya-neuraco force-pushed the fix/retry-transient-backend-errors branch 2 times, most recently from 91c0394 to 8f7d8b4 Compare July 9, 2026 22:06
@aditya-neuraco aditya-neuraco force-pushed the fix/retry-transient-backend-errors branch from 8f7d8b4 to ec27ce1 Compare July 9, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants