Skip to content

Commit 00bfe52

Browse files
ci: increase comment-pr-artifacts polling timeout (#466)
## Problem The `Comment PR Artifacts` workflow consistently times out before the `PR Build Validation` run can complete. The build pipeline typically takes 14–25 minutes (especially the Tauri macOS build), but the comment workflow only polled for ~12 minutes (30 attempts × 10-second intervals plus API overhead). This has been causing the `comment` check to fail on every PR — see PR #463 where it failed 3 consecutive times. ## Fix - Increase polling attempts from **30 → 90** - Increase sleep interval from **10s → 20s** - Effective maximum wait: ~30 minutes of sleep + API overhead ≈ 45+ minutes total This gives ample headroom for the full build matrix to complete, including slower runners like `build-tauri-macos`. ## Why this needs to merge first The `comment-pr-artifacts.yml` workflow uses `pull_request_target`, which means it runs **from the base branch (dev)**, not the PR branch. Changes to this file in PR #463 cannot take effect until this fix lands on `dev`. Once merged, the comment workflow will stop timing out on PR #463 and all future PRs. --- _This PR was created by an AI agent (OpenHands) on behalf of the user to unblock PR #463._ Co-authored-by: openhands <openhands@all-hands.dev>
1 parent 6817558 commit 00bfe52

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/comment-pr-artifacts.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ jobs:
5959
6060
const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
6161
62+
const maxAttempts = 90;
6263
let matchedRun = null;
63-
for (let attempt = 1; attempt <= 30; attempt += 1) {
64+
for (let attempt = 1; attempt <= maxAttempts; attempt += 1) {
6465
const runs = await github.paginate(github.rest.actions.listWorkflowRuns, {
6566
owner,
6667
repo,
@@ -78,8 +79,8 @@ jobs:
7879
break;
7980
}
8081
81-
core.info(`Waiting for PR Build Validation run for ${headSha} (attempt ${attempt}/30)`);
82-
await sleep(10000);
82+
core.info(`Waiting for PR Build Validation run for ${headSha} (attempt ${attempt}/${maxAttempts})`);
83+
await sleep(20000);
8384
}
8485
8586
if (!matchedRun) {

0 commit comments

Comments
 (0)