fix(tauri): fall back when WinGet updates fail

Wait for WinGet while CodeNomad remains active so launch and non-zero exit failures propagate back to the UI without blocking the async runtime.

Use one notification action path for live toasts and history entries, opening the release URL whenever the native update action rejects. Successful installs remain owned by WinGet and do not attempt an in-process restart.

Validated with the UI typecheck and build plus the Rust test suite.

Author: pascalandr

packages/tauri-app/src-tauri/src/windows_update.rs

@@ -4,26 +4,35 @@ use std::process::Command;
 use std::os::windows::process::CommandExt;
 
 #[tauri::command]
-pub fn install_stable_update() -> Result<(), String> {
-    let mut command = Command::new("winget");
-    command.args([
-        "upgrade",
-        "--exact",
-        "--id",
-        "NeuralNomadsAI.CodeNomad",
-        "--source",
-        "winget",
-        "--silent",
-        "--accept-source-agreements",
-        "--accept-package-agreements",
-        "--disable-interactivity",
-    ]);
+pub async fn install_stable_update() -> Result<(), String> {
+    tauri::async_runtime::spawn_blocking(|| {
+        let mut command = Command::new("winget");
+        command.args([
+            "upgrade",
+            "--exact",
+            "--id",
+            "NeuralNomadsAI.CodeNomad",
+            "--source",
+            "winget",
+            "--silent",
+            "--accept-source-agreements",
+            "--accept-package-agreements",
+            "--disable-interactivity",
+        ]);
 
-    #[cfg(windows)]
-    command.creation_flags(0x08000000);
+        #[cfg(windows)]
+        command.creation_flags(0x08000000);
 
-    command
-        .spawn()
-        .map(|_| ())
-        .map_err(|err| format!("Unable to start the WinGet update: {err}"))
+        let status = command
+            .status()
+            .map_err(|err| format!("Unable to start the WinGet update: {err}"))?;
+
+        if status.success() {
+            Ok(())
+        } else {
+            Err(format!("WinGet update failed with status {status}"))
+        }
+    })
+    .await
+    .map_err(|err| format!("Unable to monitor the WinGet update: {err}"))?
 }

packages/ui/src/components/toast-history-panel.tsx

@@ -21,9 +21,9 @@ import {
   deleteToastHistoryItem,
   markAllToastHistoryAsRead,
   markToastHistoryAsRead,
+  runToastAction,
   subscribeToastHistory,
 } from "../lib/notifications"
-import { isTauriHost } from "../lib/runtime-env"
 
 // ==================== Types ====================
 
@@ -188,8 +188,8 @@ const ToastHistoryPanel: Component<ToastHistoryPanelProps> = (props) => {
     }
 
     // Open action link if exists
-    if (item.action?.href) {
-      void handleOpenAction(item.action.href);
+    if (item.action) {
+      void runToastAction(item.action);
     }
   };
 
@@ -209,21 +209,6 @@ const ToastHistoryPanel: Component<ToastHistoryPanelProps> = (props) => {
     markAllToastHistoryAsRead();
   };
 
-  // Open external link
-  async function handleOpenAction(href: string): Promise<void> {
-    if (isTauriHost()) {
-      try {
-        const { openUrl } = await import("@tauri-apps/plugin-opener");
-        await openUrl(href);
-        return;
-      } catch (error) {
-        console.warn("[toast-history] unable to open via system opener", error);
-      }
-    }
-
-    window.open(href, "_blank", "noopener,noreferrer");
-  }
-
   // Stop click propagation from backdrop to panel
   const handleBackdropClick = (event: MouseEvent) => {
     if (event.target === event.currentTarget) {
@@ -383,8 +368,8 @@ const ToastHistoryPanel: Component<ToastHistoryPanelProps> = (props) => {
                                   class="toast-history-item-action inline-flex items-center gap-1 text-xs mt-1"
                                   onClick={(e) => {
                                     e.stopPropagation();
-                                    if (item.action?.href) {
-                                      void handleOpenAction(item.action.href);
+                                    if (item.action) {
+                                      void runToastAction(item.action);
                                     }
                                   }}
                                 >

packages/ui/src/lib/notifications.tsx

@@ -11,17 +11,19 @@ export type ToastHandle = {
 
 type ToastPosition = "top-left" | "top-right" | "top-center" | "bottom-left" | "bottom-right" | "bottom-center"
 
+export type ToastAction = {
+  label: string
+  href: string
+  onClick?: () => void | Promise<void>
+}
+
 export type ToastPayload = {
   title?: string
   message: string
   variant: ToastVariant
   duration?: number
   position?: ToastPosition
-  action?: {
-    label: string
-    href: string
-    onClick?: () => void | Promise<void>
-  }
+  action?: ToastAction
 }
 
 // ==================== Toast History Types ====================
@@ -43,10 +45,7 @@ export interface IToastHistoryItem {
   /** Read state (clicked) */
   read: boolean;
   /** Action link (optional) */
-  action?: {
-    label: string;
-    href: string;
-  };
+  action?: ToastAction;
 }
 
 /**
@@ -298,6 +297,20 @@ async function openExternalUrl(url: string): Promise<void> {
   }
 }
 
+export async function runToastAction(action: ToastAction): Promise<void> {
+  if (!action.onClick) {
+    await openExternalUrl(action.href)
+    return
+  }
+
+  try {
+    await action.onClick()
+  } catch (error) {
+    console.warn("[notifications] action failed; opening fallback link", error)
+    await openExternalUrl(action.href)
+  }
+}
+
 // ==================== Variant Accent Styles ====================
 
 const variantAccent: Record<
@@ -382,7 +395,7 @@ export function showToastNotification(payload: ToastPayload): ToastHandle {
               <button
                 type="button"
                 class="mt-3 inline-flex items-center text-xs font-semibold uppercase tracking-wide text-sky-300 hover:text-sky-200"
-                onClick={() => void (payload.action!.onClick?.() ?? openExternalUrl(payload.action!.href))}
+                onClick={() => void runToastAction(payload.action!)}
               >
                 {payload.action.label}
               </button>