fix(ui): keep streaming bash output pinned#556
Merged
Conversation
Streaming bash tool output bypasses the shared markdown renderer and mutates its ANSI pre element directly, so it was not participating in the same content-render notification flow as other message parts and tool call bodies. Update the running bash renderer to restore its inner scroll position immediately after ANSI DOM updates, then coalesce outer virtual-list render notifications through requestAnimationFrame. Final ANSI output uses the same notification path so completed ANSI output also re-measures consistently. This preserves the existing virtual follow-list behavior without introducing new scroll APIs or forced bottom-scroll logic, and cancels pending notification frames on unmount to avoid stale callbacks. Validation: npm run typecheck --workspace @codenomad/ui
Collaborator
Author
|
I want you to perform the gatekeeper checks for latest PR state check for regressions |
Contributor
|
Gatekeeper review for latest PR state complete. Request understood: perform a ruthless PR-quality review of #556 for regressions and better implementation options. Assumption: this is review-only; no code changes requested. Findings: none blocking. What I checked:
Validation:
Quality notes:
Residual risk:
-- |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/27626438419 Artifacts expire in 7 days.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation