feat(windows): update CodeNomad from the in-app notification#597
Conversation
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29358771230 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29360223248 Artifacts expire in 7 days.
|
bc475e0 to
34ca646
Compare
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29362803911 Artifacts expire in 7 days.
|
34ca646 to
ba663e3
Compare
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29363210154 Artifacts expire in 7 days. |
Independent subagent reviewNo blocking findings.
Residual gap: no automated tests cover Windows detection, WinGet argument construction, invocation failure, or live-toast versus history behavior. UI typecheck and Rust checks pass. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29363429383 Artifacts expire in 7 days.
|
|
@shantur LGTM |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29365404916 Artifacts expire in 7 days.
|
3 similar comments
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29365404916 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29365404916 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29365404916 Artifacts expire in 7 days.
|
Replace the official release notification link with a native WinGet upgrade on local Tauri Windows sessions. Other hosts and platforms continue opening the existing release URL. Run WinGet silently without a console window and let the NSIS installer close the application. Validated with Cargo check, the UI TypeScript check, and a live upgrade from CodeNomad 0.17.0 to 0.18.0.
Wait for WinGet while CodeNomad remains active so launch and non-zero exit failures propagate back to the UI without blocking the async runtime. Use one notification action path for live toasts and history entries, opening the release URL whenever the native update action rejects. Successful installs remain owned by WinGet and do not attempt an in-process restart. Validated with the UI typecheck and build plus the Rust test suite.
Keep history-row activation limited to marking the notification as read. Actionable operations such as WinGet updates now run only from the dedicated action button, preventing accidental installs when users select a notification. Validated with the UI TypeScript check and production build.
09e7582 to
6a493a5
Compare
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/29449487437 Artifacts expire in 7 days.
|
Route Help > Get Updates through the native WinGet updater on Windows now that PR NeuralNomadsAI#597 is merged. Run the command asynchronously so the Tauri menu event loop remains responsive. Open the latest GitHub Releases page when WinGet cannot start, exits unsuccessfully, or cannot be monitored. macOS and Linux keep the existing direct releases-page behavior. Add a focused regression test for the failed-update fallback. Validated with cargo check and all 65 Tauri tests.
## Summary - replace the inert Tauri macOS About handler with the native About dialog - add a conventional Help menu with About on Windows and Linux - expose Get Updates through each platform menu and through native About only where the platform supports an actionable link - run the native WinGet updater from the Windows Help menu, with GitHub Releases as the error fallback ## Platform behavior - macOS: CodeNomad > About CodeNomad opens the native dialog; CodeNomad > Get Updates... opens the latest GitHub release - Windows: Help > About CodeNomad opens the native dialog; Help > Get Updates... runs the WinGet updater asynchronously and opens the latest GitHub release only if WinGet cannot start, fails, or cannot be monitored - Linux: Help > About CodeNomad opens the native dialog with an actionable Get updates link; Help > Get Updates... also provides direct access - the displayed application version comes from Tauri package metadata Tauri ignores website metadata in the native macOS About panel and renders it as inert text on Windows, so website metadata is included only on Linux. ## Windows updater integration PR #597 is now merged. The Windows menu action invokes its install_stable_update command without blocking the Tauri menu event loop. macOS and Linux retain the direct Releases URL behavior. ## Validation - cargo test --manifest-path packages/tauri-app/src-tauri/Cargo.toml: 65 passed - cargo check --manifest-path packages/tauri-app/src-tauri/Cargo.toml: passed - focused failed-update fallback regression test - git diff --check: passed Closes #592
Summary
Update behavior
Validation