Skip to content

Commit d281888

Browse files
author
Kyle
committed
Support NeuroConv 0.9.0
- Bump neuroconv to 0.9.0 - Change staging=sandbox to sandbox=sandbox (neuroconv 0.9.0 API) - Remove DANDI_STAGING_API_KEY from CI (neuroconv 0.9.0 uses dandi-sandbox natively)
1 parent ad29175 commit d281888

6 files changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/testing_dev_e2e_with_live_services.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ jobs:
7979
run: |
8080
touch .env
8181
echo DANDI_SANDBOX_API_KEY=${{ secrets.DANDI_SANDBOX_API_KEY }} >> .env
82-
echo DANDI_STAGING_API_KEY=${{ secrets.DANDI_SANDBOX_API_KEY }} >> .env
8382
8483
- if: matrix.os != 'ubuntu-latest'
8584
name: Run tests

environments/environment-Linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ dependencies:
1515
- flask-cors == 4.0.0
1616
- flask_restx == 1.1.0
1717
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
18-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
18+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
1919
- scikit-learn == 1.4.0 # Tutorial data generation
2020
- tqdm_publisher >= 0.0.1 # Progress bars
2121
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-MAC-apple-silicon.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies:
2424
# NOTE: the NeuroConv wheel on PyPI includes sonpy which is not compatible with arm64, so build and install
2525
# NeuroConv from GitHub, which will remove the sonpy dependency when building from Mac arm64
2626
- h5py < 3.13 # 3.13+ uses HDF5 1.14.4 features not in pytables 3.10.2's bundled HDF5 1.14.2
27-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
27+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2828
- scikit-learn == 1.4.0 # Tutorial data generation
2929
- tqdm_publisher >= 0.0.1 # Progress bars
3030
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-MAC-intel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- flask-cors == 4.0.0
1919
- flask_restx == 1.1.0
2020
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
21-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
21+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2222
- scikit-learn == 1.4.0 # Tutorial data generation
2323
- tqdm_publisher >= 0.0.1 # Progress bars
2424
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-Windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- flask-cors === 3.0.10
1919
- flask_restx == 1.1.0
2020
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
21-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
21+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2222
- scikit-learn == 1.4.0 # Tutorial data generation
2323
- tqdm_publisher >= 0.0.1 # Progress bars
2424
- tzlocal >= 5.2 # Frontend timezone handling

src/pyflask/manageNeuroconv/manage_neuroconv.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,7 +1436,7 @@ def upload_folder_to_dandi(
14361436
return automatic_dandi_upload(
14371437
dandiset_id=dandiset_id,
14381438
nwb_folder_path=Path(nwb_folder_path),
1439-
staging=sandbox, # Map sandbox parameter to staging for external API
1439+
sandbox=sandbox,
14401440
cleanup=cleanup,
14411441
number_of_jobs=number_of_jobs or 1,
14421442
number_of_threads=number_of_threads or 1,
@@ -1471,7 +1471,7 @@ def upload_project_to_dandi(
14711471
return automatic_dandi_upload(
14721472
dandiset_id=dandiset_id,
14731473
nwb_folder_path=CONVERSION_SAVE_FOLDER_PATH / project, # Scope valid DANDI upload paths to GUIDE projects
1474-
staging=sandbox, # Map sandbox parameter to staging for external API
1474+
sandbox=sandbox,
14751475
cleanup=cleanup,
14761476
number_of_jobs=number_of_jobs,
14771477
number_of_threads=number_of_threads,

0 commit comments

Comments
 (0)