Merge pull request #1067 from NeurodataWithoutBorders/fix-set-output-deprecation

Fix deprecated set-output and behavior cache key typo

Author: bendichter

.github/workflows/example_data_cache.yml

@@ -17,6 +17,9 @@ jobs:
     # Requirement settings identified as 'ExampleDataCache / {os}'
     name: ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
+    defaults:
+      run:
+        shell: bash
     strategy:
       fail-fast: false
       matrix:
@@ -27,7 +30,10 @@ jobs:
 
       - name: Get ephy_testing_data current head hash
         id: ephys
-        run: echo "::set-output name=HASH_EPHY_DATASET::$(git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch ephy_testing_data hash" && exit 1; fi
+          echo "HASH_EPHY_DATASET=$HASH" >> $GITHUB_OUTPUT
       - name: Get cached ephys example data - ${{ steps.ephys.outputs.HASH_EPHY_DATASET }}
         uses: actions/cache@v4
         id: cache-ephys-datasets
@@ -36,7 +42,10 @@ jobs:
           key: ephys-datasets-v2-${{ matrix.os }}-${{ steps.ephys.outputs.HASH_EPHY_DATASET }}
       - name: Get ophys_testing_data current head hash
         id: ophys
-        run: echo "::set-output name=HASH_OPHYS_DATASET::$(git ls-remote https://gin.g-node.org/CatalystNeuro/ophys_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/CatalystNeuro/ophys_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch ophys_testing_data hash" && exit 1; fi
+          echo "HASH_OPHYS_DATASET=$HASH" >> $GITHUB_OUTPUT
       - name: Get cached ophys example data - ${{ steps.ophys.outputs.HASH_OPHYS_DATASET }}
         uses: actions/cache@v4
         id: cache-ophys-datasets
@@ -45,13 +54,16 @@ jobs:
           key: ophys-datasets-${{ matrix.os }}-${{ steps.ophys.outputs.HASH_OPHYS_DATASET }}
       - name: Get behavior_testing_data current head hash
         id: behavior
-        run: echo "::set-output name=HASH_BEHAVIOR_DATASET::$(git ls-remote https://gin.g-node.org/CatalystNeuro/behavior_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/CatalystNeuro/behavior_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch behavior_testing_data hash" && exit 1; fi
+          echo "HASH_BEHAVIOR_DATASET=$HASH" >> $GITHUB_OUTPUT
       - name: Get cached behavior example data - ${{ steps.behavior.outputs.HASH_BEHAVIOR_DATASET }}
         uses: actions/cache@v4
         id: cache-behavior-datasets
         with:
           path: ./behavior_testing_data
-          key: behavior-datasets-${{ matrix.os }}-${{ steps.behavior.outputs.HASH_behavior_DATASET }}
+          key: behavior-datasets-${{ matrix.os }}-${{ steps.behavior.outputs.HASH_BEHAVIOR_DATASET }}
 
       - if: steps.cache-ephys-datasets.outputs.cache-hit != 'true' || steps.cache-ophys-datasets.outputs.cache-hit != 'true' || steps.cache-behavior-datasets.outputs.cache-hit != 'true'
         name: Install and configure AWS CLI

.github/workflows/testing_pipelines.yml

@@ -73,7 +73,10 @@ jobs:
       # Load example data caches
       - name: Get ephy_testing_data current head hash
         id: ephys
-        run: echo "::set-output name=HASH_EPHY_DATASET::$(git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch ephy_testing_data hash" && exit 1; fi
+          echo "HASH_EPHY_DATASET=$HASH" >> $GITHUB_OUTPUT
 
       - name: Cache ephys dataset - ${{ steps.ephys.outputs.HASH_EPHY_DATASET }}
         uses: actions/cache@v4
@@ -84,7 +87,10 @@ jobs:
 
       - name: Get ophys_testing_data current head hash
         id: ophys
-        run: echo "::set-output name=HASH_OPHYS_DATASET::$(git ls-remote https://gin.g-node.org/CatalystNeuro/ophys_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/CatalystNeuro/ophys_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch ophys_testing_data hash" && exit 1; fi
+          echo "HASH_OPHYS_DATASET=$HASH" >> $GITHUB_OUTPUT
 
       - name: Cache ophys dataset - ${{ steps.ophys.outputs.HASH_OPHYS_DATASET }}
         uses: actions/cache@v4
@@ -95,14 +101,17 @@ jobs:
 
       - name: Get behavior_testing_data current head hash
         id: behavior
-        run: echo "::set-output name=HASH_BEHAVIOR_DATASET::$(git ls-remote https://gin.g-node.org/CatalystNeuro/behavior_testing_data.git HEAD | cut -f1)"
+        run: |
+          HASH=$(git ls-remote https://gin.g-node.org/CatalystNeuro/behavior_testing_data.git HEAD | cut -f1)
+          if [ -z "$HASH" ]; then echo "Failed to fetch behavior_testing_data hash" && exit 1; fi
+          echo "HASH_BEHAVIOR_DATASET=$HASH" >> $GITHUB_OUTPUT
 
       - name: Cache behavior dataset - ${{ steps.behavior.outputs.HASH_BEHAVIOR_DATASET }}
         uses: actions/cache@v4
         id: cache-behavior-datasets
         with:
           path: ./behavior_testing_data
-          key: behavior-datasets-${{ matrix.os }}-${{ steps.behavior.outputs.HASH_behavior_DATASET }}
+          key: behavior-datasets-${{ matrix.os }}-${{ steps.behavior.outputs.HASH_BEHAVIOR_DATASET }}
 
       # Run pipeline tests
       - if: matrix.os != 'ubuntu-latest'