Skip to content

Commit e5f47f2

Browse files
author
Kyle
committed
Support NeuroConv 0.9.0
Changes from 0.8.0: - Bump neuroconv to 0.9.0 - Remove dandi < 0.74.0 pin - Remove DANDI_STAGING_API_KEY - Use sandbox= parameter for automatic_dandi_upload
1 parent 7ced663 commit e5f47f2

6 files changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/testing_dev_e2e_with_live_services.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ jobs:
7979
run: |
8080
touch .env
8181
echo DANDI_SANDBOX_API_KEY=${{ secrets.DANDI_SANDBOX_API_KEY }} >> .env
82-
echo DANDI_STAGING_API_KEY=${{ secrets.DANDI_SANDBOX_API_KEY }} >> .env
8382
8483
- if: matrix.os != 'ubuntu-latest'
8584
name: Run tests

environments/environment-Linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ dependencies:
1515
- flask-cors == 4.0.0
1616
- flask_restx == 1.1.0
1717
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
18-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
18+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
1919
- scikit-learn == 1.4.0 # Tutorial data generation
2020
- tqdm_publisher >= 0.0.1 # Progress bars
2121
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-MAC-apple-silicon.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ dependencies:
2323
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
2424
# NOTE: the NeuroConv wheel on PyPI includes sonpy which is not compatible with arm64, so build and install
2525
# NeuroConv from GitHub, which will remove the sonpy dependency when building from Mac arm64
26-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
26+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2727
- scikit-learn == 1.4.0 # Tutorial data generation
2828
- tqdm_publisher >= 0.0.1 # Progress bars
2929
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-MAC-intel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- flask-cors == 4.0.0
1919
- flask_restx == 1.1.0
2020
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
21-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
21+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2222
- scikit-learn == 1.4.0 # Tutorial data generation
2323
- tqdm_publisher >= 0.0.1 # Progress bars
2424
- tzlocal >= 5.2 # Frontend timezone handling

environments/environment-Windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- flask-cors === 3.0.10
1919
- flask_restx == 1.1.0
2020
- werkzeug < 3.0 # werkzeug 3.0 deprecates features used by flask 2.3.2. Remove this when updating flask.
21-
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.8.0
21+
- neuroconv[dandi,compressors,ecephys,ophys,behavior,text] == 0.9.0
2222
- scikit-learn == 1.4.0 # Tutorial data generation
2323
- tqdm_publisher >= 0.0.1 # Progress bars
2424
- tzlocal >= 5.2 # Frontend timezone handling

src/pyflask/manageNeuroconv/manage_neuroconv.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,7 +1413,7 @@ def upload_folder_to_dandi(
14131413
return automatic_dandi_upload(
14141414
dandiset_id=dandiset_id,
14151415
nwb_folder_path=Path(nwb_folder_path),
1416-
staging=sandbox, # Map sandbox parameter to staging for external API
1416+
sandbox=sandbox, # Map sandbox parameter to staging for external API
14171417
cleanup=cleanup,
14181418
number_of_jobs=number_of_jobs or 1,
14191419
number_of_threads=number_of_threads or 1,
@@ -1449,7 +1449,7 @@ def upload_project_to_dandi(
14491449
return automatic_dandi_upload(
14501450
dandiset_id=dandiset_id,
14511451
nwb_folder_path=CONVERSION_SAVE_FOLDER_PATH / project, # Scope valid DANDI upload paths to GUIDE projects
1452-
staging=sandbox, # Map sandbox parameter to staging for external API
1452+
sandbox=sandbox, # Map sandbox parameter to staging for external API
14531453
cleanup=cleanup,
14541454
number_of_jobs=number_of_jobs,
14551455
number_of_threads=number_of_threads,

0 commit comments

Comments
 (0)