Add 7 previously excluded neuroconv interfaces to NWB GUIDE#1058
Closed
bendichter wants to merge 2 commits intomainfrom
Closed
Add 7 previously excluded neuroconv interfaces to NWB GUIDE#1058bendichter wants to merge 2 commits intomainfrom
bendichter wants to merge 2 commits intomainfrom
Conversation
Remove the following interfaces from exclude_interfaces_from_selection: - CsvTimeIntervalsInterface - ExcelTimeIntervalsInterface - Hdf5ImagingInterface - MaxOneRecordingInterface - OpenEphysSortingInterface - AxonaPositionDataInterface - AxonaUnitRecordingInterface These interfaces are available in neuroconv 0.9.1 and were previously excluded without clear justification. They are now exposed in the interface selection UI. Interfaces that remain excluded: - SpikeGLXLFPInterface (deprecated) - CEDRecordingInterface, OpenEphysBinaryRecordingInterface, OpenEphysLegacyRecordingInterface (aliases) - SimaSegmentationInterface (unmaintained dependency) Also adds test_new_interfaces.py verifying each new interface appears in get_all_interface_info() and has a valid source schema.
for more information, see https://pre-commit.ci
Collaborator
Author
|
Closing — will add interfaces one at a time with local test verification instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 7 interfaces from the
exclude_interfaces_from_selectionlist inget_all_interface_info(), making them available in the NWB GUIDE interface selection UI. These interfaces exist in neuroconv 0.9.1 and were previously excluded.Newly available interfaces:
Still excluded (with reason):
SpikeGLXLFPInterface(deprecated)CEDRecordingInterface,OpenEphysBinaryRecordingInterface,OpenEphysLegacyRecordingInterface(aliases)SimaSegmentationInterface(unmaintained SIMA dependency)Notes
ExternalVideoInterfaceandScanImageImagingInterfaceare already included (not in the exclude list) but have display name collisions withInternalVideoInterfaceandScanImageLegacyImagingInterfacerespectively — this is a neuroconv upstream issue.test_new_interfaces.pywith 19 tests verifying inclusion/exclusion and source schema retrieval.Testing
pytest src/pyflask/tests/test_neuroconv.py src/pyflask/tests/test_new_interfaces.py— 22 passed)