Use random endpoint for neurosift files to fix incorrect caching#986
Merged
Use random endpoint for neurosift files to fix incorrect caching#986
Conversation
for more information, see https://pre-commit.ci
Collaborator
pauladkisson
left a comment
pauladkisson
left a comment
There was a problem hiding this comment.
Random string seems less transparent, what about using an index + date modified instead?
Collaborator
Author
|
Great idea! I made that change. |
pauladkisson
approved these changes
May 15, 2025
Collaborator
pauladkisson
left a comment
pauladkisson
left a comment
There was a problem hiding this comment.
Not sure why the e2eLiveServices tests are failing, but otherwise looks good.
Collaborator
Author
|
They are failing due to #987 . I'll address that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #974
The new endpoint is
/files/<string:file_id>where file_id is a string with 8 random letters and numbers, which is highly unlikely to repeat before the Neurosift cache resets (currently after 1000 entries)See comments in #974 for rationale of using a random string instead of other schemes.
Clearing the Neurosift cache database doesn't work from the GUIDE domain so I removed that code and test.