Handle new interface format keywords from NeuroConv 0.6.0#997
Merged
Conversation
Collaborator
Author
|
The new JSON schema / NeuroConv 0.6.0 also means:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #957.
Address #957 (comment)
format: file->format: file-pathandformat: directory->format: directory-pathamong other changes.file-pathanddirectory-pathinstead offileanddirectoryfor displaying a file selector vs directory selectorformat: file-pathandformat: directory-path. I think I caught all the instances.Alternatively, I could have converted the JSON Schema on read to change
file-pathback tofileand not change the rest of GUIDE, but 1) I thinkfile-pathis more informative, and 2) that conversion feels less clean.Other changes in the interfaces will be addressed in a separate PR to keep this one clean.