Skip to content

Commit 81cee96

Browse files
authored
Merge pull request #481 from NeurodataWithoutBorders/fix/imageseries2
Make ImageSeries/data required
2 parents 345d022 + 477f921 commit 81cee96

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

core/nwb.image.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ groups:
6363
- null
6464
- null
6565
- null
66-
doc: Binary data representing images across frames.
67-
quantity: '?'
66+
doc: Binary data representing images across frames. If data are stored in an external
67+
file, this should be an empty 3D array.
6868
- name: dimension
6969
dtype: int32
7070
dims:

docs/format/source/format_release_notes.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ Release Notes
77
- Fix incorrect dtype for electrodes table column "filtering" (float -> text)
88
- Remove "quantity: *" from the type definitions of ``OptogeneticStimulusSite`` and ``ImagingPlane``.
99
This change improves clarity of the schema to follow best practices. It has no functional effect on the schema.
10+
- Require the "data" dataset in ``ImageSeries``. Since ``ImageSeries`` is a ``TimeSeries`` and ``TimeSeries`` requires
11+
the "data" dataset, ``ImageSeries`` should also require the "data" dataset. Otherwise this creates problems for
12+
inheritance and validation. If ``ImageSeries`` data are stored in an external file, then "data" should be set to
13+
an empty 3D array.
1014
1115
2.3.0 (May 12, 2021)
1216
---------------------

0 commit comments

Comments
 (0)