Skip to content

Commit 95d62d6

Browse files
rlyclaude
andauthored
Fix external-file ImageSeries test and require pynwb>=4.0 (#708)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 09cff81 commit 95d62d6

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
### New Checks
44

55
### Improvements
6+
* Raised the minimum required PyNWB to `>=4.0` to track the latest PyNWB release. [#708](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/708)
67
* Bumped GitHub Actions workflow dependencies (`actions/checkout` v4 -> v6, `actions/setup-python` v5 -> v6, `codecov/codecov-action` v4 -> v5) to migrate off Node.js 20, which GitHub is removing from runners on 2026-09-16. [#702](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/702)
78

89
### Fixes
10+
* Fixed unit tests that failed at construction time against recent PyNWB and HDMF. [#707](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/707) [#708](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/708)
911
* Skipped Ontobee in the documentation external link check, which frequently timed out and caused spurious CI failures. [#709](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/709)
10-
* Fixed unit tests that failed at construction time against recent PyNWB and HDMF. [#707](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/707)
1112
* Fixed `run_checks` raising `TypeError` when a `progress_bar_class` was passed without `progress_bar_options`; the keyword arguments are now coalesced to an empty dict before being forwarded to the progress-bar constructor. [#701](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/701)
1213

1314
# v0.7.2 (May 19, 2026)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ classifiers = [
3333
]
3434
requires-python = ">=3.10"
3535
dependencies = [
36-
"pynwb>=3.1", # NWB Inspector should always be used with most recent minor versions of PyNWB
36+
"pynwb>=4.0", # NWB Inspector should always be used with most recent minor versions of PyNWB
3737
"fsspec",
3838
"requests",
3939
"aiohttp",

tests/unit_tests/test_image_series.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ def test_check_image_series_external_file_valid_bytestring_pass(self):
5858
rate=1.0,
5959
external_file=[bytes("/".join([".", good_external_path.name]), "utf-8")],
6060
format="external",
61+
num_samples=1,
6162
)
6263
assert check_image_series_external_file_relative(image_series=image_series) is None
6364

0 commit comments

Comments
 (0)